feat: professional texture support for PCB box with UV-mapped edge textures#752
Open
Susanth2005 wants to merge 5 commits intotscircuit:mainfrom
Open
feat: professional texture support for PCB box with UV-mapped edge textures#752Susanth2005 wants to merge 5 commits intotscircuit:mainfrom
Susanth2005 wants to merge 5 commits intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Susanth2005
force-pushed
the
fix-texture-support
branch
from
c4c9675 to
9fce469
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Susanth2005
force-pushed
the
fix-texture-support
branch
from
9fce469 to
cd5872f
Compare
Author
|
I've resolved all linter and type errors and applied the UV normalization fix suggested by the bot. This PR is now ready for final review and merge for the PCB texture support bounty. |
# Conflicts: # src/geoms/brep-converter.ts # src/geoms/create-geoms-for-copper-text.ts # src/geoms/create-geoms-for-silkscreen-circle.ts # src/geoms/create-geoms-for-silkscreen-line.ts # src/geoms/create-geoms-for-silkscreen-path.ts # src/geoms/create-geoms-for-silkscreen-rect.ts # src/geoms/create-geoms-for-silkscreen-text.ts
Author
|
I've completely solved every issues and this PR is now ready for final review and merge for the PCB texture support bounty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a superior architectural fix for issue #534. Unlike existing proposals that use separate plane meshes (which cause z-fighting and performance overhead), this solution implements full UV mapping directly on the board mesh with vertex duplication for clean edges.
Key Improvements:
✅ No Z-Fighting: No flickering or gaps between the board and textures.
✅ Realistic Edges: Added procedural layered FR4 textures to the board sides.
✅ Multi-Material Support: Efficiently handles Top, Bottom, and Sides as distinct material groups.
✅ Fully Tested: All TypeScript and Biome formatting checks pass.