Fix for Firefox 136+: Replace removed JSM imports with ESM#11
Open
oxidworks wants to merge 1 commit intotsaost:mainfrom
Open
Fix for Firefox 136+: Replace removed JSM imports with ESM#11oxidworks wants to merge 1 commit intotsaost:mainfrom
oxidworks wants to merge 1 commit intotsaost:mainfrom
Conversation
Firefox 136 removed ChromeUtils.import() and all legacy JSM modules.
This breaks the original userChrome.js which used:
- Components.utils.import("resource://gre/modules/Services.jsm")
- Components.utils.import("resource://gre/modules/AddonManager.jsm")
- Components.utils.import("resource://gre/modules/FileUtils.jsm")
Replaced with ESM equivalents:
- globalThis.Services
- ChromeUtils.importESModule("resource://gre/modules/AddonManager.sys.mjs")
- ChromeUtils.importESModule("resource://gre/modules/FileUtils.sys.mjs")
Tested on Firefox 148 (Linux).
Also simplified userChrome.js and updated README with Linux/macOS install instructions.
oxidworks
force-pushed
the
fix/esm-firefox-136
branch
from
773807c to
6df50bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox 136 completed ESMification and removed
ChromeUtils.import()along with all legacy JSM modules. This brokeuserChrome.jsbecause it relied on:Components.utils.import("resource://gre/modules/Services.jsm")Components.utils.import("resource://gre/modules/AddonManager.jsm")Components.utils.import("resource://gre/modules/FileUtils.jsm")This PR replaces them with the ESM equivalents:
Tested on Firefox 148 (Linux). Also simplified
userChrome.jsand added Linux/macOS install paths to the README.Fixes #5, #7, #8, #9 (related to Firefox compatibility issues).