-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix error handling gaps in recent releases #3639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
deepshekhardas
wants to merge
7
commits into
triggerdotdev:main
from
deepshekhardas:fix/pr-3530-release-branch
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0b53066
ci(release): support release/* branches with version-comparison gating
ericallam 64309e5
ci(release): combine GITHUB_OUTPUT writes into a single block (SC2129)
ericallam b0e4550
docs(scripts): add JSDoc to enhance-release-pr.mjs new/changed functions
ericallam fdb1119
docs(scripts): JSDoc the remaining functions in enhance-release-pr.mjs
ericallam 5f73a3f
fix: release branch issues - npm retry + semver comparison
9c3a802
Fix release workflow indentation and version comparison
fccc2fc
Fix error handling gaps in recent releases
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Missing mollifierDrainerWorker.server module will break the webapp build
The new import at
apps/webapp/app/entry.server.tsx:250references~/v3/mollifierDrainerWorker.server, but no file matching this path exists anywhere in the repository (verified viafindandgrep). This will cause a build failure. Not reported as a bug per review guidelines since it would be caught by the type checker / bundler, but the reviewer should be aware that this PR cannot build the webapp as-is.Was this helpful? React with 👍 or 👎 to provide feedback.