fix(engine): allow disabling the ttl system consumers independently from the whole system by ericallam · Pull Request #3115 · triggerdotdev/trigger.dev

ericallam · 2026-02-23T16:34:03Z

No description provided.

…rom the whole system

changeset-bot · 2026-02-23T16:34:09Z

⚠️ No Changeset found

Latest commit: e23326c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-02-23T16:34:25Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae46e3f and e23326c.

📒 Files selected for processing (5)

apps/webapp/app/env.server.ts
apps/webapp/app/v3/runEngine.server.ts
internal-packages/run-engine/src/engine/index.ts
internal-packages/run-engine/src/engine/types.ts
internal-packages/run-engine/src/run-queue/index.ts

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)

GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
GitHub Check: sdk-compat / Node.js 20.20 (ubuntu-latest)
GitHub Check: sdk-compat / Cloudflare Workers
GitHub Check: sdk-compat / Node.js 22.12 (ubuntu-latest)
GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
GitHub Check: sdk-compat / Deno Runtime
GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
GitHub Check: sdk-compat / Bun Runtime
GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
GitHub Check: typecheck / typecheck

🧰 Additional context used

📓 Path-based instructions (7)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead

**/*.{ts,tsx}: Always import tasks from @trigger.dev/sdk, never use @trigger.dev/sdk/v3 or deprecated client.defineJob pattern
Every Trigger.dev task must be exported and have a unique id property with no timeouts in the run function

Files:

apps/webapp/app/v3/runEngine.server.ts
apps/webapp/app/env.server.ts
internal-packages/run-engine/src/run-queue/index.ts
internal-packages/run-engine/src/engine/index.ts
internal-packages/run-engine/src/engine/types.ts

{packages/core,apps/webapp}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use zod for validation in packages/core and apps/webapp

Files:

apps/webapp/app/v3/runEngine.server.ts
apps/webapp/app/env.server.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use function declarations instead of default exports

Import from @trigger.dev/core using subpaths only, never import from root

Files:

apps/webapp/app/v3/runEngine.server.ts
apps/webapp/app/env.server.ts
internal-packages/run-engine/src/run-queue/index.ts
internal-packages/run-engine/src/engine/index.ts
internal-packages/run-engine/src/engine/types.ts

apps/webapp/app/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

Access all environment variables through the env export of env.server.ts instead of directly accessing process.env in the Trigger.dev webapp

Files:

apps/webapp/app/v3/runEngine.server.ts
apps/webapp/app/env.server.ts

apps/webapp/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

apps/webapp/**/*.{ts,tsx}: When importing from @trigger.dev/core in the webapp, use subpath exports from the package.json instead of importing from the root path
Follow the Remix 2.1.0 and Express server conventions when updating the main trigger.dev webapp

Access environment variables via env export from apps/webapp/app/env.server.ts, never use process.env directly

Files:

apps/webapp/app/v3/runEngine.server.ts
apps/webapp/app/env.server.ts

**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)

**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries

Files:

apps/webapp/app/v3/runEngine.server.ts
apps/webapp/app/env.server.ts
internal-packages/run-engine/src/run-queue/index.ts
internal-packages/run-engine/src/engine/index.ts
internal-packages/run-engine/src/engine/types.ts

**/*.{js,ts,jsx,tsx,json,md,yaml,yml}

📄 CodeRabbit inference engine (AGENTS.md)

Format code using Prettier before committing

Files:

apps/webapp/app/v3/runEngine.server.ts
apps/webapp/app/env.server.ts
internal-packages/run-engine/src/run-queue/index.ts
internal-packages/run-engine/src/engine/index.ts
internal-packages/run-engine/src/engine/types.ts

🧠 Learnings (5)

📚 Learning: 2025-11-27T16:26:58.661Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2025-11-27T16:26:58.661Z
Learning: Applies to apps/webapp/app/**/*.{ts,tsx} : Access all environment variables through the `env` export of `env.server.ts` instead of directly accessing `process.env` in the Trigger.dev webapp

Applied to files:

apps/webapp/app/env.server.ts

📚 Learning: 2026-01-15T11:50:06.067Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-15T11:50:06.067Z
Learning: Applies to apps/webapp/**/*.{ts,tsx} : Access environment variables via `env` export from `apps/webapp/app/env.server.ts`, never use `process.env` directly

Applied to files:

apps/webapp/app/env.server.ts

📚 Learning: 2026-01-15T11:50:06.067Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-15T11:50:06.067Z
Learning: Applies to apps/webapp/**/*.test.{ts,tsx} : For testable code in the webapp, never import env.server.ts in test files - pass configuration as options instead

Applied to files:

apps/webapp/app/env.server.ts

📚 Learning: 2025-08-14T18:35:44.370Z

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 2390
File: apps/webapp/app/env.server.ts:764-765
Timestamp: 2025-08-14T18:35:44.370Z
Learning: The BoolEnv helper in apps/webapp/app/utils/boolEnv.ts uses z.preprocess with inconsistent default value types across the codebase - some usages pass boolean defaults (correct) while others pass string defaults (incorrect), leading to type confusion. The helper should enforce boolean-only defaults or have clearer documentation.

Applied to files:

apps/webapp/app/env.server.ts

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger.config.ts : Specify runtime environment (node or bun) in trigger.config.ts using the `runtime` property

Applied to files:

apps/webapp/app/env.server.ts

🧬 Code graph analysis (2)

apps/webapp/app/env.server.ts (2)

apps/webapp/app/utils/boolEnv.ts (1)

BoolEnv (12-14)

apps/supervisor/src/envUtil.ts (1)

BoolEnv (15-17)

internal-packages/run-engine/src/engine/index.ts (1)

internal-packages/run-engine/src/run-queue/index.ts (2)

options (1154-1170)

options (1242-1263)

🔇 Additional comments (7)

apps/webapp/app/v3/runEngine.server.ts (1)

83-92: Good wiring for per-instance TTL consumer control.

The new consumersDisabled flag is correctly passed through the RunEngine configuration.

internal-packages/run-engine/src/run-queue/index.ts (2)

95-105: TTL option extension looks solid.

The new consumersDisabled option is well documented and fits the existing TTL config model.

1242-1252: Consumer gating behavior is clear and safe.

Short-circuiting TTL consumers on a per-instance flag is exactly what’s needed.

apps/webapp/app/env.server.ts (1)

609-617: Env schema addition is consistent.

RUN_ENGINE_TTL_CONSUMERS_DISABLED is defined with a sensible default.

internal-packages/run-engine/src/engine/types.ts (1)

66-78: TTL option docs are clearer with the new flag.

The consumersDisabled addition aligns with the intended behavior.

internal-packages/run-engine/src/engine/index.ts (2)

192-202: Pass-through of consumersDisabled is correct.

RunQueue receives the new TTL option as expected.

370-374: TTL worker start condition matches the new semantics.

The gating logic now aligns with the per-instance consumer toggle.

Walkthrough

This pull request adds a new configuration flag consumersDisabled to the TTL (time-to-live) system within the Run Engine. The change flows through multiple layers: an environment variable RUN_ENGINE_TTL_CONSUMERS_DISABLED is added to the application configuration, passed through the RunEngine initialization, and integrated into the Run Engine package's TTL system options. When this flag is enabled, TTL consumers and workers are prevented from starting, though ZADD operations during enqueue continue to function normally. The existing disabled flag for the entire TTL system remains unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description is completely empty and lacks all required template sections including testing steps, changelog entry, and checklist completion.	Add a complete pull request description following the template with issue reference, testing steps, changelog entry, and completed checklist.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding a way to disable TTL system consumers independently from disabling the entire TTL system.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/ttl-consumers-disabled

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

fix(engine): allow disabling the ttl system consumers independently f…

e23326c

…rom the whole system

devin-ai-integration bot reviewed Feb 23, 2026

View reviewed changes

ericallam marked this pull request as ready for review February 23, 2026 16:37

matt-aitken approved these changes Feb 23, 2026

View reviewed changes

ericallam merged commit 6409fea into main Feb 23, 2026
34 of 35 checks passed

ericallam deleted the fix/ttl-consumers-disabled branch February 23, 2026 16:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

fix(engine): allow disabling the ttl system consumers independently from the whole system#3115

fix(engine): allow disabling the ttl system consumers independently from the whole system#3115
ericallam merged 1 commit intomainfrom
fix/ttl-consumers-disabled

ericallam commented Feb 23, 2026

Uh oh!

changeset-bot bot commented Feb 23, 2026

Uh oh!

coderabbitai bot commented Feb 23, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

ericallam commented Feb 23, 2026

Uh oh!

changeset-bot bot commented Feb 23, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Feb 23, 2026 •

edited

Loading