Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions apps/webapp/app/components/runs/v3/RunFilters.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -648,15 +648,28 @@ function TasksDropdown({
<ComboBox placeholder={"Filter by task..."} value={searchValue} />
<SelectList>
{filtered.map((item, index) => (
<SelectItem
key={`${item.triggerSource}-${item.slug}`}
value={item.slug}
icon={
<TaskTriggerSourceIcon source={item.triggerSource} className="size-4 flex-none" />
}
>
<MiddleTruncate text={item.slug}/>
</SelectItem>
<TooltipProvider key={`${item.triggerSource}-${item.slug}`}>
<Tooltip>
<TooltipTrigger asChild>
<div className="w-full">
<SelectItem
value={item.slug}
icon={
<TaskTriggerSourceIcon
source={item.triggerSource}
className="size-4 flex-none"
/>
}
>
<MiddleTruncate text={item.slug} />
</SelectItem>
</div>
</TooltipTrigger>
<TooltipContent side="right" sideOffset={8}>
<Paragraph variant="extra-small">{item.slug}</Paragraph>
</TooltipContent>
</Tooltip>
</TooltipProvider>
Comment on lines +651 to +672

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Tooltip wrapping pattern differs from existing status dropdown convention

The new code wraps SelectItem inside TooltipProvider > Tooltip > TooltipTrigger > div (lines 651-672), while the existing status dropdown at apps/webapp/app/components/runs/v3/RunFilters.tsx:557-568 places TooltipProvider > Tooltip > TooltipTrigger inside SelectItem as children.

The status dropdown pattern is arguably safer because SelectItem remains a direct DOM descendant of SelectList, with no intermediate non-Ariakit wrapper elements. In the new pattern, a <div className="w-full"> sits between SelectList and SelectItem. While this works because Ariakit uses querySelectorAll with role-based selectors (not direct-children checks), adopting the interior-tooltip pattern used by the status dropdown would be more consistent and avoid any risk of future Ariakit updates changing item discovery behavior.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

))}
</SelectList>
</SelectPopover>
Expand Down