Refine SSH auth ordering and password fallback#144
Open
shcheklein wants to merge 3 commits intotreeverse:mainfrom
Open
Refine SSH auth ordering and password fallback#144shcheklein wants to merge 3 commits intotreeverse:mainfrom
shcheklein wants to merge 3 commits intotreeverse:mainfrom
Conversation
for more information, see https://pre-commit.ci
shcheklein
force-pushed
the
fix-ssh-auth-ordering-kbdint-fallback
branch
2 times, most recently
from
9538b1d to
5794215
Compare
shcheklein
force-pushed
the
fix-ssh-auth-ordering-kbdint-fallback
branch
from
5794215 to
7148f99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of #143 and #141
This rewrites the earlier SSH password prompt fix around a narrower, protocol-aware auth selection strategy while keeping the keyboard-interactive password fallback fix.
Changes:
password,keyboard-interactivefor password-based loginspublickeywhen explicit key material is configuredpreferred_authconstructionThis should address unnecessary publickey/passphrase prompts without breaking servers which expose password login only through
keyboard-interactive.