mds: run on lakefs-enterprise image via lakefs mds run#395
Merged
Conversation
|
|
Switch the MDS deployment to the `treeverse/lakefs-enterprise` image and invoke it as `lakefs mds run`, replacing the legacy standalone Python MDS container. The `mds.image.repository` / `mds.image.tag` defaults fall through to `treeverse/lakefs-enterprise` and `image.enterprise.tag` via new helpers, and `mds.command` / `mds.args` let users override the container ENTRYPOINT and arguments. To roll back, override the image fields and `mds.args` (and re-add the legacy `lakefs:` / `metadata_settings:` config and `PYTHONPATH` env) without further chart changes. Drops the now-unneeded `PYTHONPATH` workaround for the Python image. Bumps chart to 1.10.0. https://claude.ai/code/session_01K7WeQ1doQLnWsXY2EEvGNR
The rollback path is documented in values.yaml; the CHANGELOG entry should describe the change itself, not migration knobs. https://claude.ai/code/session_01K7WeQ1doQLnWsXY2EEvGNR
The helpers and `with` blocks in the deployment already fall back when these keys are absent, so the empty values added noise without changing behaviour. https://claude.ai/code/session_01K7WeQ1doQLnWsXY2EEvGNR
1067d3d to
993d249
Compare
3 tasks
…mds-service-LheIw # Conflicts: # CHANGELOG.md # charts/lakefs/Chart.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #396
Summary
treeverse/lakefs-enterpriseimage and invokes it aslakefs mds run, replacing the legacy standalone Python MDS container.mds.repository/mds.taghelpers:mds.image.repositorydefaults totreeverse/lakefs-enterprise,mds.image.tagfalls back toimage.enterprise.tagso the MDS pod tracks the lakeFS server version by default.mds.commandandmds.argsvalues let users override the container ENTRYPOINT and arguments. Defaultargs: ["mds", "run", "--config", "/app/config.yaml"]overrides the lakeFS image's["run"]CMD.PYTHONPATHenv workaround that was tied to the old MDS image.mds.configto match the lakeFS Enterprisemetadata_searchschema.1.10.0with CHANGELOG entry.Rollback (no chart edits required)
Test plan
helm lint charts/lakefshelm template charts/lakefs --set mds.enabled=truerenders the deployment withimage: treeverse/lakefs-enterprise:<image.enterprise.tag>andargs: [mds, run, --config, /app/config.yaml], nocommand:field, noPYTHONPATHenv.helm template charts/lakefs --set mds.enabled=true --set mds.image.repository=treeverse/mds --set mds.image.tag=0.2.1 --set 'mds.args={--config,/app/config.yaml}'renders the legacy image with the legacy args./healthendpoint responds.https://claude.ai/code/session_01K7WeQ1doQLnWsXY2EEvGNR