Skip to content

mds: run on lakefs-enterprise image via lakefs mds run#395

Merged
N-o-Z merged 4 commits into
masterfrom
claude/update-helm-mds-service-LheIw
May 14, 2026
Merged

mds: run on lakefs-enterprise image via lakefs mds run#395
N-o-Z merged 4 commits into
masterfrom
claude/update-helm-mds-service-LheIw

Conversation

@N-o-Z
Copy link
Copy Markdown
Member

@N-o-Z N-o-Z commented May 7, 2026

Closes #396

Summary

  • Switches the MDS deployment to the treeverse/lakefs-enterprise image and invokes it as lakefs mds run, replacing the legacy standalone Python MDS container.
  • New mds.repository / mds.tag helpers: mds.image.repository defaults to treeverse/lakefs-enterprise, mds.image.tag falls back to image.enterprise.tag so the MDS pod tracks the lakeFS server version by default.
  • New mds.command and mds.args values let users override the container ENTRYPOINT and arguments. Default args: ["mds", "run", "--config", "/app/config.yaml"] overrides the lakeFS image's ["run"] CMD.
  • Drops the Python-specific PYTHONPATH env workaround that was tied to the old MDS image.
  • Refreshes the example mds.config to match the lakeFS Enterprise metadata_search schema.
  • Bumps chart to 1.10.0 with CHANGELOG entry.

Rollback (no chart edits required)

mds:
  image:
    repository: treeverse/mds
    tag: "0.2.1"
  args: ["--config", "/app/config.yaml"]
  extraEnvVars:
    - name: PYTHONPATH
      value: /home/arktika/.local/lib/python3.13/site-packages
  config:
    lakefs: { endpoint: ..., access_key_id: ..., secret_access_key: ... }
    metadata_settings: { since: ..., max_commits: 100 }
    repositories: { ... }

Test plan

  • helm lint charts/lakefs
  • helm template charts/lakefs --set mds.enabled=true renders the deployment with image: treeverse/lakefs-enterprise:<image.enterprise.tag> and args: [mds, run, --config, /app/config.yaml], no command: field, no PYTHONPATH env.
  • helm template charts/lakefs --set mds.enabled=true --set mds.image.repository=treeverse/mds --set mds.image.tag=0.2.1 --set 'mds.args={--config,/app/config.yaml}' renders the legacy image with the legacy args.
  • Deploy to a cluster with a valid enterprise license and verify the MDS pod becomes ready and the /health endpoint responds.

https://claude.ai/code/session_01K7WeQ1doQLnWsXY2EEvGNR

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 7, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ N-o-Z
❌ claude
You have signed the CLA already but the status is still pending? Let us recheck it.

claude added 3 commits May 7, 2026 18:17
Switch the MDS deployment to the `treeverse/lakefs-enterprise` image and
invoke it as `lakefs mds run`, replacing the legacy standalone Python MDS
container. The `mds.image.repository` / `mds.image.tag` defaults fall
through to `treeverse/lakefs-enterprise` and `image.enterprise.tag` via
new helpers, and `mds.command` / `mds.args` let users override the
container ENTRYPOINT and arguments. To roll back, override the image
fields and `mds.args` (and re-add the legacy `lakefs:` /
`metadata_settings:` config and `PYTHONPATH` env) without further chart
changes. Drops the now-unneeded `PYTHONPATH` workaround for the Python
image. Bumps chart to 1.10.0.

https://claude.ai/code/session_01K7WeQ1doQLnWsXY2EEvGNR
The rollback path is documented in values.yaml; the CHANGELOG entry
should describe the change itself, not migration knobs.

https://claude.ai/code/session_01K7WeQ1doQLnWsXY2EEvGNR
The helpers and `with` blocks in the deployment already fall back when
these keys are absent, so the empty values added noise without changing
behaviour.

https://claude.ai/code/session_01K7WeQ1doQLnWsXY2EEvGNR
@N-o-Z N-o-Z force-pushed the claude/update-helm-mds-service-LheIw branch from 1067d3d to 993d249 Compare May 7, 2026 18:18
@N-o-Z N-o-Z self-assigned this May 7, 2026
@N-o-Z N-o-Z requested review from guy-har and nopcoder May 7, 2026 19:51
@N-o-Z N-o-Z marked this pull request as ready for review May 7, 2026 19:51
…mds-service-LheIw

# Conflicts:
#	CHANGELOG.md
#	charts/lakefs/Chart.yaml
Copy link
Copy Markdown
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@N-o-Z N-o-Z merged commit 0f1532b into master May 14, 2026
3 of 4 checks passed
@N-o-Z N-o-Z deleted the claude/update-helm-mds-service-LheIw branch May 14, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm: switch MDS deployment to lakefs-enterprise image with lakefs mds run

4 participants