Skip to content

fix: include oz_governor proposer in transitive sender resolution #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nvtaveras wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: include oz_governor proposer in transitive sender resolution #62

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
124c629
fix: include oz_governor proposer in transitive sender resolution
nvtaveras Mar 20, 2026
1f81377
Merge branch 'main' into fix/missingGovernorSender
nvtaveras Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions internal/config/senders.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,25 @@ func (m *SendersManager) BuildSenderScriptConfig(
return nil, fmt.Errorf("can not use ledger and trezor senders in the same script, configure @custom:senders")
}

var safeSigners []string
// Collect transitive sender dependencies: senders not in @custom:senders but
// referenced by declared senders (e.g. a safe's signer or a governor's proposer).
// These must be included in SENDER_CONFIGS so the Solidity registry can look them up.
var transitiveSenders []string
if m.config != nil && m.config.Senders != nil {
for _, senderKey := range senders {
if sender, exists := m.config.Senders[senderKey]; exists && sender.Type == "safe" {
safeSigners = append(safeSigners, sender.Signer)
sender, exists := m.config.Senders[senderKey]
if !exists {
continue
}
switch sender.Type {
case "safe":
transitiveSenders = append(transitiveSenders, sender.Signer)
case "oz_governor":
transitiveSenders = append(transitiveSenders, sender.Proposer)
}
}
}
signersHWConfig := m.getSendersHWConfig(safeSigners)
signersHWConfig := m.getSendersHWConfig(transitiveSenders)

if signersHWConfig.UseLedger && executionHWConfig.UseLedger {
return nil, fmt.Errorf("can not use ledger in both main sender and safe signer, configure @custom:senders")
Expand All @@ -82,9 +92,9 @@ func (m *SendersManager) BuildSenderScriptConfig(
return nil, fmt.Errorf("can not use ledger in both main sender and safe signer, configure @custom:senders")
}

sort.Strings(safeSigners)
sort.Strings(transitiveSenders)
sort.Strings(senders)
allSenders := append(slices.Clone(safeSigners), senders...)
allSenders := append(slices.Clone(transitiveSenders), senders...)

var senderInitConfigs []config.SenderInitConfig
if senderInitConfigs, err = m.buildSenderInitConfigs(allSenders); err != nil {
Expand Down
Loading