Remove legacy files from ROI Reporting Agent#434
Merged
toru-takahashi merged 1 commit intoApr 13, 2026
Merged
Conversation
…gent push Legacy root-level files (agent.yml, tools.yml, system_prompt.md) caused tdx agent push to register empty tools/outputs. Old-format form interfaces (td_managed_*.yml using form_json_schema) caused push validation errors. Duplicate knowledge base .md files at the project root were confusing. - Delete 10 legacy/duplicate files (-1,051 lines) - Add prompt_file to Dashboard Viz/agent.yml - Update README with concrete UI manual setup instructions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the ROI Reporting Agent configuration to prevent tdx agent push conflicts/validation errors by removing legacy duplicate root-level configs and pointing the active agent definition at the correct prompt file. It also updates the English/Japanese READMEs with concrete UI-based setup steps so users can manually configure the project without relying on internal docs.
Changes:
- Deleted legacy/duplicate agent config, system prompt, tool config, KB spec, and deprecated form interface files that were conflicting with the canonical structure.
- Updated
Dashboard Viz/agent.ymlto load the system prompt viaprompt_file: prompt.md. - Replaced the README “manual configuration” sections (EN/JA) with step-by-step Agent Foundry UI setup instructions.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| engage-box/roi_reporting/agent/tools.yml | Removed legacy tool config in favor of embedded tools/outputs in Dashboard Viz/agent.yml. |
| engage-box/roi_reporting/agent/system_prompt.md | Removed legacy prompt file; canonical prompt now lives under Dashboard Viz/. |
| engage-box/roi_reporting/agent/system_prompt_JA.md | Removed legacy Japanese prompt file; Japanese reference prompt exists under Dashboard Viz/. |
| engage-box/roi_reporting/agent/README.md | Replaced legacy/manual setup note with concrete UI configuration steps. |
| engage-box/roi_reporting/agent/README_JA.md | Same UI setup guidance update in Japanese. |
| engage-box/roi_reporting/agent/knowledge_base_overall_summary.md | Removed duplicate root-level Overall Summary spec (canonical is under knowledge_bases/). |
| engage-box/roi_reporting/agent/knowledge_base_overall_summary_JA.md | Removed duplicate root-level Japanese Overall Summary spec (canonical is under knowledge_bases/). |
| engage-box/roi_reporting/agent/knowledge_base_campaign_details.md | Removed duplicate root-level Campaign Details spec (canonical is under knowledge_bases/). |
| engage-box/roi_reporting/agent/knowledge_base_campaign_details_JA.md | Removed duplicate root-level Japanese Campaign Details spec (canonical is under knowledge_bases/). |
| engage-box/roi_reporting/agent/form_interfaces/td_managed_overall_summary.yml | Removed deprecated form interface format (form_json_schema / JSON strings). |
| engage-box/roi_reporting/agent/form_interfaces/td_managed_campaign_details.yml | Removed deprecated form interface format (form_json_schema / JSON strings). |
| engage-box/roi_reporting/agent/Dashboard Viz/agent.yml | Added prompt_file: prompt.md so the agent loads the correct system prompt. |
| engage-box/roi_reporting/agent/agent.yml | Removed legacy root-level agent config that conflicted with Dashboard Viz/agent.yml. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
toru-takahashi
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engage-box/roi_reporting/agent/that causedtdx agent pushto fail or register empty tools/outputsprompt_file: prompt.mdtoDashboard Viz/agent.ymlso the system prompt is loaded correctlyProblem
When running
tdx agent push .from the project root, three issues occurred:agent.yml/tools.yml/system_prompt.mdconflicted withDashboard Viz/agent.yml, causing tools (0/4) and outputs (0/3) to be empty after pushtd_managed_*.ymlform interfaces used oldform_json_schemaformat instead of the currentform_schema(YAML object), causing validation errorsknowledge_base_*.mdfiles at the project root were confusing — the canonical versions live inknowledge_bases/Changes
Deleted files (10)
agent.yml(root)Dashboard Viz/agent.ymltools.ymlDashboard Viz/agent.ymlsystem_prompt.md/system_prompt_JA.mdDashboard Viz/prompt.mdknowledge_base_overall_summary.md/_JA.mdknowledge_bases/OverallSummary_Spec.mdknowledge_base_campaign_details.md/_JA.mdknowledge_bases/CampaignDetails_Spec.mdform_interfaces/td_managed_campaign_details.ymlform_json_schema); replaced byCampaign Details.ymlform_interfaces/td_managed_overall_summary.ymlOverall Summary.ymlModified files (3)
Dashboard Viz/agent.ymlprompt_file: prompt.mdREADME.mdREADME_JA.mdTest plan
tdx agent push .fromengage-box/roi_reporting/agent/succeeds without errors🤖 Generated with Claude Code