Use sha384 signatures for list requests#42
Merged
Conversation
Member
|
@tim-kos note that we at least need 256 for CDN support |
…st-signatures # Conflicts: # Makefile
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=======================================
Coverage 82.60% 82.60%
=======================================
Files 6 6
Lines 345 345
=======================================
Hits 285 285
Misses 32 32
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
listRequest()signature generation from SHA-1 to SHA-384sha384:algorithm prefix for list-request signaturessign()uses sha384 with prefixlistRequest()uses sha384 with prefixWhy
api2issue https://github.com/transloadit/api2/issues/5337 tracks SDK support for SHA-384 signatures.The Go SDK already used SHA-384 for normal request signing, but
listRequest()still used SHA-1 without a prefix. This made signature behavior inconsistent and could break accounts defaulting to SHA-384.Notes