little improvement of translator ach.po#3253
little improvement of translator ach.po#3253taufiqsumadi wants to merge 3 commits intotranslate:masterfrom
Conversation
I found some bugs: 1. Different whitespace at the end 2. missing variable 3. Different XML tags 4. Different functions 5. Different whitespace at the end 6. Different numbers I hope some improvements can be helpful ;)
Different numbers and different quotation.
Different whitespace at the end, and different quotation marks.
jayvdb
left a comment
jayvdb
left a comment
There was a problem hiding this comment.
I am just highlighting changes that the maintainers should focus on.
| #, python-format | ||
| msgid "Add \"%s\" to Dictionary" | ||
| msgstr "Přidat „%s“ do slovníku" | ||
| msgstr "Přidat \"%s\" do slovníku" |
There was a problem hiding this comment.
This change needs to be reviewed carefully. Maybe smart quotes are better.
There was a problem hiding this comment.
Quoting styles are language specific. This looks perfectly correct for cs. Likely you ran pofilter with specifying a language as there are language specific adaptation.
| #, python-format | ||
| msgid "Look-up \"%(selection)s\"" | ||
| msgstr "Vyhledat „%(selection)s“" | ||
| msgstr "Vyhledat \"%(selection)s\"" |
| #, python-format | ||
| msgid "\"%s\" is not a usable file." | ||
| msgstr "„%s“ není použitelný soubor." | ||
| msgstr "\"%s\" není použitelný soubor." |
| #: ../bin/virtaal:135 | ||
| msgid "Could not open log file '%(filename)s'" | ||
| msgstr "Soubor záznamu ‚%(filename)s‘ se nepodařilo otevřít" | ||
| msgstr "Soubor záznamu '%(filename)s' se nepodařilo otevřít" |
| #: ../bin/virtaal:143 | ||
| msgid "Could not read configuration file '%(filename)s'" | ||
| msgstr "Konfigurační soubor ‚%(filename)s‘ se nepodařilo načíst" | ||
| msgstr "Konfigurační soubor '%(filename)s' se nepodařilo načíst" |
| #: ../bin/virtaal:185 | ||
| msgid "Could not open profile file '%(filename)s'" | ||
| msgstr "Profilovací soubor ‚%(filename)s‘ se nepodařilo otevřít" | ||
| msgstr "Profilovací soubor '%(filename)s' se nepodařilo otevřít" |
| msgid "To mark the current translation as fuzzy, simply press <Alt+U>." | ||
| msgstr "" | ||
| "Per segnare la presente traduzione come \"fuzzy\", basta premere <Alt+U>." | ||
| "Per segnare la presente traduzione come fuzzy, basta premere <Alt+U>." |
There was a problem hiding this comment.
Adding quotes around English words is fairly common in translations.
There was a problem hiding this comment.
The translator is highlighting that the word fuzzy here is untranslated or borrowed, so leave the quotes. The quotes checker is a guide not a hard and fast rule. This we'd consider a false positive.
| "To mark the current translation as incomplete, simply press <Ctrl+Shift" | ||
| "+Enter>." | ||
| msgstr "" | ||
| "Per segnare la presente traduzione come \"incompleta\", basta premere <Ctrl" |
There was a problem hiding this comment.
interesting change; perhaps the source string should have quotes around it.
| #: ../virtaal/tips.py:33 | ||
| msgid "To mark the current translation as complete, simply press <Ctrl+Enter>." | ||
| msgstr "" | ||
| "Per segnare la presente traduzione come \"completa\", basta premere <Ctrl" |
There was a problem hiding this comment.
likewise quotes in the source string might be helpful.
dwaynebailey
left a comment
dwaynebailey
left a comment
There was a problem hiding this comment.
We use technical failures to indicate issues in the translated text. By cleaning these up and not having a translator clean them up we lost some of these markers.
That said the patch is fine to land with some fixes.
There are only one or two quotes fixes that are correct. '' -> " is correct. The others are different quote styles or using quotes in the target. Those are all fine.
Trailing whitespace and punctuation fixes can land.
Fixing is risky in that there could be bigger issues, but they can land.
Fixing variables. The usually all need fixing. The %s one is easy as its almost always an issue. The %filename is harder as we don't know how the language works in terms of prefixing such words. But all those can land.
Thanks for the patch, there are some good fixes here.
| #, python-format | ||
| msgid "%.1f KB" | ||
| msgstr "%.1f kB" | ||
| msgstr "%.1f KB" |
There was a problem hiding this comment.
The ACRONYM filter is dumb. It is simply flagging potential errors. kB is perfectly correct in some locales, in fact our source could be considered incorrect.
| #: ../virtaal/views/widgets/aboutdialog.py:34 | ||
| msgid "Copyright © 2007-2010 Zuza Software Foundation" | ||
| msgstr "Copyright © 2007-2011 Zuza Software Foundation" | ||
| msgstr "Copyright © 2007-2010 Zuza Software Foundation" |
There was a problem hiding this comment.
I wouldn't worry about this number as its part of a date range. Likely the source should say 2007-2016. So its OK to land, just not critical and not more correct.
| "one." | ||
| msgstr "" | ||
| "Alla fine della traduzione, premere semplicemente <Invio> per continuare con " | ||
| "Alla fine della traduzione, premere semplicemente <Enter> per continuare con " |
There was a problem hiding this comment.
The problem with correcting any of these 'XML' is that they probably need a review of the whole string from a language perspective. Lets land this one, but be aware that you don't know the software enough to know if someone has just reused another string.
| msgid "To mark the current translation as fuzzy, simply press <Alt+U>." | ||
| msgstr "" | ||
| "Per segnare la presente traduzione come \"fuzzy\", basta premere <Alt+U>." | ||
| "Per segnare la presente traduzione come fuzzy, basta premere <Alt+U>." |
There was a problem hiding this comment.
The translator is highlighting that the word fuzzy here is untranslated or borrowed, so leave the quotes. The quotes checker is a guide not a hard and fast rule. This we'd consider a false positive.
| "To mark the current translation as incomplete, simply press <Ctrl+Shift" | ||
| "+Enter>." | ||
| msgstr "" | ||
| "Per segnare la presente traduzione come \"incompleta\", basta premere <Ctrl" |
3 participants
I found some bugs:
I hope some improvements can be helpful ;) @julen