Skip to content
This repository was archived by the owner on Sep 23, 2024. It is now read-only.

Distinguish between nulls and empty strings#69

Open
tombriggsallego wants to merge 2 commits intotransferwise:masterfrom
tombriggsallego:emptyStringsNotNull
Open

Distinguish between nulls and empty strings#69
tombriggsallego wants to merge 2 commits intotransferwise:masterfrom
tombriggsallego:emptyStringsNotNull

Conversation

@tombriggsallego
Copy link
Copy Markdown

Problem

Treat empty strings as non-null for varchar fields. Fixes #68

Almost everything I know about Python I learned in order to fix this so there may well be a better way to do it. ;)

Proposed changes

Uses a specific token string to signify NULLs in the COPY command, then doesn't produce that value in the CSV if a given field is a varchar and is an empty string.

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty strings get stored as null

1 participant