This repository was archived by the owner on Sep 23, 2024. It is now read-only.
Distinguish between nulls and empty strings#69
Open
tombriggsallego wants to merge 2 commits intotransferwise:masterfrom
Open
Distinguish between nulls and empty strings#69tombriggsallego wants to merge 2 commits intotransferwise:masterfrom
tombriggsallego wants to merge 2 commits intotransferwise:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Treat empty strings as non-null for varchar fields. Fixes #68
Almost everything I know about Python I learned in order to fix this so there may well be a better way to do it. ;)
Proposed changes
Uses a specific token string to signify NULLs in the COPY command, then doesn't produce that value in the CSV if a given field is a varchar and is an empty string.
Types of changes
What types of changes does your code introduce to PipelineWise?
Put an
xin the boxes that applyChecklist
setup.pyis an individual PR and not mixed with feature or bugfix PRs[AP-NNNN](if applicable. AP-NNNN = JIRA ID)AP-NNN(if applicable. AP-NNN = JIRA ID)