Consider changing Composer package type to "phpcodesniffer-standard"#7
Consider changing Composer package type to "phpcodesniffer-standard"#7rodrigoprimo wants to merge 1 commit intotraderinteractive:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details🔇 Additional comments (1)
Summary by CodeRabbit
WalkthroughThe pull request adds a Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan for PR comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR suggests changing the Composer package type to enable automatic standard registration via the PHPCSStandards Composer installer plugin.
Problem/Motivation
Composer allows declaring a package's type. When no type is declared, the default is "library".
There is a Composer plugin that can install custom PHP_CodeSniffer standards: https://github.com/PHPCSStandards/composer-installer
This plugin is part of the PHPCSStandards organisation, which is the new official home of PHP_CodeSniffer.
For this installer to work, the package type needs to be set to
phpcodesniffer-standard.There are already over 470 packages that use this type. As a side benefit, using this type will allow end-users to more easily find other external PHP_CodeSniffer standards that may be interesting to them when searching on Packagist.
Proposed changes
Add
"type": "phpcodesniffer-standard"tocomposer.json.This will in no way change the existing behavior of this package for users that do not include the Composer plugin mentioned above in their projects'
composer.json.