Conversation
…SAST (ops-q2hs)
Move ${{ github.sha }} and ${{ github.ref_name }} out of run: blocks
into env: blocks, referenced as $GITHUB_SHA and $GITHUB_REF_NAME
inside run:. Standard Semgrep-recommended pattern to avoid shell
injection via untrusted github context expressions.
Affects: preflight verify steps + all 3 publish steps in release.yml
tps-sherlock
approved these changes
Apr 28, 2026
Contributor
tps-sherlock
left a comment
tps-sherlock
left a comment
There was a problem hiding this comment.
APPROVED -- standard Semgrep hardening, no behavioral change.
Security verification:
(1) ${{ github.sha }} moved from inline shell to env: GITHUB_SHA:
env:
GITHUB_SHA: ${{ github.sha }}
run: |
if ! git merge-base --is-ancestor $GITHUB_SHA origin/main; then(2) ${{ github.ref_name }} moved from inline shell to env: GITHUB_REF_NAME (4 occurrences):
env:
GITHUB_REF_NAME: ${{ github.ref_name }}
run: |
VERSION="$GITHUB_REF_NAME"(3) ${{ secrets.NPM_TOKEN }} already in env, repositioned -- no change in exposure:
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}(4) Zero runtime code changed -- purely workflow YAML hardening against CWE-78 (command injection via GitHub context).
LGTM.
tps-kern
approved these changes
Apr 28, 2026
tps-kern
left a comment
tps-kern
left a comment
There was a problem hiding this comment.
ops-q2hs review: APPROVED — Semgrep fix: ${{ github.* }} moved to env blocks in release.yml; YAML structure verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ops-q2hs: Fix Semgrep SAST shell-injection findings in release.yml
Refactored all
${{ github.* }}expressions fromrun:blocks intoenv:blocks using the standard Semgrep-recommended pattern.Changes
All 5 Semgrep findings fixed:
Verify tag is on main:${{ github.sha }}→$GITHUB_SHA,${{ github.ref_name }}→$GITHUB_REF_NAMEVerify package versions match tag:${{ github.ref_name }}→$GITHUB_REF_NAMEPublish agent package:${{ github.ref_name }}→$GITHUB_REF_NAMEPublish platform packages:${{ github.ref_name }}→$GITHUB_REF_NAMEPublish meta package:${{ github.ref_name }}→$GITHUB_REF_NAMENo behavioral change — env var references are equivalent at runtime.