feat(timeout): WIP TotalTimeoutBody for absolute timeout#653
Conversation
ghost
closed this by deleting the head repository
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Hi everyone!
I saw issue #630 about needing a timeout that doesn't reset on every frame, and I thought I'd try to implement the core logic for it. I think this could also be beneficial for preventing slowloris (form of DDoS attack) but lmk if it's actually not the case!
Solution
I've implemented TotalTimeoutBody. It's a struct that enforces an absolute deadline on the request/response body. Unlike the existing TimeoutBody (which resets the timer on every byte), this one guarantees the connection closes after a fixed time.
I haven't added the tests or the Layer structs (middleware) yet. I wanted to open this PR first to ask:
If the answer is yes, I'll happily add the middleware layers (it'll be almost a 1-to-1 copy of the existing timeout layers) and the tests to make sure it catches those slow requests.