Fix bugs in lazy and stabilize it#1900
Open
marshallku wants to merge 8 commits intomainfrom
Open
Conversation
People can be co-author:
|
🦋 Changeset detectedLatest commit: 1733815 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
marshallku
commented
Feb 2, 2026
| } | ||
|
|
||
| const loadNoReturn = () => load().then(noop) | ||
| const loadNoReturn = Object.assign(() => load().then(noop), { toString: () => load.toString() }) |
Collaborator
Author
There was a problem hiding this comment.
We check the loading state of a component using Function.toString(), but it always returns the same value when the function is set like load().then(noop).
marshallku
commented
Feb 2, 2026
| const reloadCount = parseInt(storedValue, 10) | ||
| if (Number.isNaN(reloadCount)) reloadStorage.removeItem(storageKey) | ||
| currentRetryCount = reloadCount | ||
| if (Number.isNaN(reloadCount)) { |
Collaborator
Author
There was a problem hiding this comment.
NaN was silently killing lazy
Contributor
|
Size Change: -147 B (-0.24%) Total Size: 59.9 kB
ℹ️ View Unchanged
|
manudeli
reviewed
Feb 3, 2026
| } | ||
|
|
||
| const loadNoReturn = () => load().then(noop) | ||
| const loadNoReturn = Object.assign(() => load().then(noop), { toString: () => load.toString() }) |
Member
There was a problem hiding this comment.
Suggested change
| const loadNoReturn = Object.assign(() => load().then(noop), { toString: () => load.toString() }) | |
| const loadNoReturn = load |
Then How about this? We can just pass load directly too.
Collaborator
Author
There was a problem hiding this comment.
load actually returns a value, so it'll break type system.
Member
There was a problem hiding this comment.
it'll break type system.
But it's not BREAKING CHANGE because lazy was an experimental interface yet. so I want you just care about which one is better implementation
Collaborator
Author
There was a problem hiding this comment.
I just simplified it!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1900 +/- ##
=======================================
Coverage 94.04% 94.05%
=======================================
Files 41 41
Lines 655 656 +1
Branches 166 167 +1
=======================================
+ Hits 616 617 +1
Misses 36 36
Partials 3 3
🚀 New features to boost your workflow:
|
manudeli
force-pushed
the
feat/stable-lazy
branch
from
60e60ee to
1733815
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixed several bugs in lazy and removed the
@experimentaltag to mark it as stable.Additional features I'm currently working on:
These are considered feature additions rather than stabilization work, so they will be handled in separate PRs.
PR Checklist