Solve for "i" not defined AND adding in a "is_current" property for each...#4
Solve for "i" not defined AND adding in a "is_current" property for each...#4csprocket777 wants to merge 1 commit into
Conversation
…ach page in Pages So I'm finding this class useful. However when I implemented it, I found that I received an error stating that "i" was not defined. This simply defines the variable in the for loop. Also, I thought it was a nice shortcut to add an "is_current" property to each page that references the "currentPage" property of the mixin.
|
Awesome! Would you be able to writing a jasmine test (in the current test file) to show this broken without the fix you applied? Thank you in advance |
|
Unfortunately I have NO experience with Jasmine. Is this something I would need to do before you accept the PR? -Chuck On Nov 2, 2013, at 8:19 PM, Toran Billups notifications@github.com wrote:
|
|
To be completely honest this example was built with the sole purpose of showing how to do pagination with ember and how to test it in isolation. Jasmine itself doesn't have a steep learning curve and this would be a great learning opportunity (as this isn't production code for anyone). How do the tests run currently on your machine with these changes? If you first install everything using npm install (from the project root), you can run all the tests like so node node_modules/jasmine-phantom-node/bin/jasmine-phantom-node example/static |
2 participants
... page in Pages
So I'm finding this class useful. However when I implemented it, I found that I received an error stating that "i" was not defined. This simply defines the variable in the for loop.
Also, I thought it was a nice shortcut to add an "is_current" property to each page that references the "currentPage" property of the mixin.