Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| INSERT INTO "groups"."GroupMember" ("id", "groupId", "memberId", "membershipType", "createdBy") | ||
| VALUES (${groupMemberId}, ${groupId}, ${memberId}, ${membershipType}, ${createdBy}) | ||
| INSERT INTO "groups"."GroupMember" ("id", "groupId", "memberId", "membershipType", "roles", "createdAt", "createdBy", "updatedAt", "updatedBy") | ||
| VALUES (${groupMemberId}, ${groupId}, ${memberId}, ${membershipType}, '{}', NOW(), ${createdBy}, NOW(), ${createdBy}) |
There was a problem hiding this comment.
[correctness]
The roles column is being set to an empty JSON object ('{}'). If this is intended to be an array or a more complex JSON structure, consider using [] for an empty array or ensure the structure matches the expected schema to avoid potential issues with data handling later.
| INSERT INTO "groups"."GroupMember" ("id", "groupId", "memberId", "membershipType", "createdBy") | ||
| VALUES (${groupMemberId}, ${groupId}, ${memberId}, ${membershipType}, ${createdBy}) | ||
| INSERT INTO "groups"."GroupMember" ("id", "groupId", "memberId", "membershipType", "roles", "createdAt", "createdBy", "updatedAt", "updatedBy") | ||
| VALUES (${groupMemberId}, ${groupId}, ${memberId}, ${membershipType}, '{}', NOW(), ${createdBy}, NOW(), ${createdBy}) |
There was a problem hiding this comment.
[💡 design]
The use of NOW() for createdAt and updatedAt assumes that the database server's time is accurate and synchronized. Consider using a consistent time source or service if time accuracy is critical for your application.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.