[PROD RELEASE] - Jan 26 by kkartunov · Pull Request #27 · topcoder-platform/identity-api-v6

kkartunov · 2026-02-03T08:07:46Z

No description provided.

feat: created identity schema external cient

… proxy url for caching

…S-522)

…6 into develop

PM-3576 - use auth0 proxy for token caching

github-actions · 2026-02-03T08:08:09Z

packages/identity-prisma-client/client.d.ts

@@ -0,0 +1 @@
+export * from "./index"


[💡 style]
Consider adding a newline at the end of the file to adhere to POSIX standards. This can help prevent issues with some tools and version control systems that expect a newline at the end of files.

github-actions · 2026-02-03T08:08:13Z

packages/identity-prisma-client/default.d.ts

@@ -0,0 +1 @@
+export * from "./index"


[💡 style]
Consider adding a newline at the end of the file to adhere to POSIX standards and improve compatibility with various tools and systems.

github-actions · 2026-02-03T08:08:16Z

packages/identity-prisma-client/default.js

+/* !!! This is code generated by Prisma. Do not edit directly. !!!
+/* eslint-disable */
+// biome-ignore-all lint: generated file
+module.exports = { ...require('#main-entry-point') }


[❗❗ correctness]
Using require with a dynamic path like '#main-entry-point' can lead to issues if the module resolution fails or if the path is incorrect. Consider verifying that this path is correct and that the module exists to prevent runtime errors.

github-actions · 2026-02-03T08:08:19Z

packages/identity-prisma-client/edge.d.ts

@@ -0,0 +1 @@
+export * from "./default"


[💡 style]
Consider adding a newline at the end of the file. While this is a minor style issue, it can prevent potential issues with certain tools or version control systems that expect a newline at the end of files.

github-actions · 2026-02-03T08:08:24Z

packages/identity-prisma-client/index-browser.js

+  engine: "c2990dca591cba766e3b7ef5d9e8a84796e47ab7"
+}
+
+Prisma.PrismaClientKnownRequestError = () => {


[⚠️ maintainability]
The error message construction in PrismaClientKnownRequestError and similar functions is repeated multiple times. Consider refactoring this into a helper function to improve maintainability and reduce duplication.

github-actions · 2026-02-03T08:08:24Z

packages/identity-prisma-client/index-browser.js

+exports.Prisma.Security_userScalarFieldEnum = {
+  login_id: 'login_id',
+  user_id: 'user_id',
+  password: 'password',


[❗❗ security]
Storing passwords in plain text within the Security_userScalarFieldEnum is a security risk. Ensure that passwords are hashed and not stored in plain text to enhance security.

github-actions · 2026-02-03T08:08:24Z

packages/identity-prisma-client/index-browser.js

+  timezone_id: 'timezone_id',
+  last_site_hit_date: 'last_site_hit_date',
+  name_in_another_language: 'name_in_another_language',
+  password: 'password',


[❗❗ security]
Storing passwords in plain text within the UserScalarFieldEnum is a security risk. Ensure that passwords are hashed and not stored in plain text to enhance security.

Copilot

Pull request overview

This is a production release pull request titled "[PROD RELEASE] - Jan 26" that includes a mix of code formatting improvements, functionality enhancements, and major database client refactoring. The changes also include generated Prisma client files with developer-specific configurations.

Changes:

Code formatting standardization (semicolons, quotes, line breaks across multiple files)
Removal of M2M token caching logic from MemberApiService
Enhancement of APP_DOMAIN configuration to check configService before environment variables
Major refactoring of user group management to use a new group-specific Prisma client
Addition of new Prisma client generator for external client output

Reviewed changes

Copilot reviewed 33 out of 53 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
src/shared/util/pagination.util.ts	Added semicolons for consistency
src/shared/util/common.utils.ts	Enhanced getAppDomain to check configService first
src/shared/member-api/member-api.service.ts	Removed token caching mechanism
src/api/user/user.service.ts	Refactored to use separate group Prisma client and updated group membership creation
src/api/user/user.service.spec.ts	Added mock for new group Prisma client
prisma/schema.prisma	Added externalClient generator configuration
packages/identity-prisma-client/*	Generated Prisma client files with local development paths
Multiple controller/service files	Code formatting improvements (quotes, spacing, line breaks)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-03T08:13:19Z

packages/identity-prisma-client/wasm.js

+      "value": "prisma-client-js"
+    },
+    "output": {
+      "value": "/Users/hentrymartin/development/identity-api-v6/packages/identity-prisma-client",


Developer-specific local path detected. The generated Prisma client contains a hardcoded path '/Users/hentrymartin/development/identity-api-v6/packages/identity-prisma-client' that is specific to the developer's machine. This will cause runtime errors in other environments. The Prisma client must be regenerated before deployment.

Suggested change

"value": "/Users/hentrymartin/development/identity-api-v6/packages/identity-prisma-client",

"value": __dirname,

Copilot · 2026-02-03T08:13:20Z

packages/identity-prisma-client/index-browser.js

+  makeStrictEnum,
+  Public,
+  getRuntime,
+  skip


Unused variable skip.

Suggested change

skip

Copilot · 2026-02-03T08:13:20Z

packages/identity-prisma-client/index.js

+  empty,
+  join,
+  raw,
+  skip,


Unused variable skip.

Suggested change

skip,

Copilot · 2026-02-03T08:13:20Z

packages/identity-prisma-client/index.js

+  raw,
+  skip,
+  Decimal,
+  Debug,


Unused variable Debug.

Suggested change

Debug,

Copilot · 2026-02-03T08:13:21Z

packages/identity-prisma-client/index.js

+  objectEnumValues,
+  makeStrictEnum,
+  Extensions,
+  warnOnce,


Unused variable warnOnce.

Suggested change

warnOnce,

Copilot · 2026-02-03T08:13:21Z

packages/identity-prisma-client/wasm.js

+  empty,
+  join,
+  raw,
+  skip,


Unused variable skip.

Suggested change

skip,

Copilot · 2026-02-03T08:13:22Z

packages/identity-prisma-client/wasm.js

+  objectEnumValues,
+  makeStrictEnum,
+  Extensions,
+  warnOnce,


Unused variable warnOnce.

Suggested change

warnOnce,

Copilot · 2026-02-03T08:13:22Z

packages/identity-prisma-client/wasm.js

+  warnOnce,
+  defineDmmfProperty,
+  Public,
+  getRuntime,


Unused variable getRuntime.

Suggested change

getRuntime,

Copilot · 2026-02-03T08:13:22Z

packages/identity-prisma-client/wasm.js

+  defineDmmfProperty,
+  Public,
+  getRuntime,
+  createParam,


Unused variable createParam.

Suggested change

createParam,

Copilot · 2026-02-03T08:13:22Z

packages/identity-prisma-client/wasm.js

+if (typeof globalThis !== 'undefined' && globalThis['DEBUG'] || typeof process !== 'undefined' && process.env && process.env.DEBUG || undefined) {
+  Debug.enable(typeof globalThis !== 'undefined' && globalThis['DEBUG'] || typeof process !== 'undefined' && process.env && process.env.DEBUG || undefined)


This use of variable 'undefined' always evaluates to false.

Suggested change

if (typeof globalThis !== 'undefined' && globalThis['DEBUG'] || typeof process !== 'undefined' && process.env && process.env.DEBUG || undefined) {

Debug.enable(typeof globalThis !== 'undefined' && globalThis['DEBUG'] || typeof process !== 'undefined' && process.env && process.env.DEBUG || undefined)

if (typeof globalThis !== 'undefined' && globalThis['DEBUG'] || typeof process !== 'undefined' && process.env && process.env.DEBUG) {

Debug.enable(typeof globalThis !== 'undefined' && globalThis['DEBUG'] || typeof process !== 'undefined' && process.env && process.env.DEBUG)

hentrymartin and others added 6 commits January 28, 2026 22:07

feat: created identity schema external cient

f6b09aa

Merge pull request #25 from topcoder-platform/identity-external-client

6ca5877

feat: created identity schema external cient

Remove manual caching for m2m token when fetching member details. use…

771cce0

… proxy url for caching

Lint fixes and group db client used when creating group membership (P…

ce8ebb4

…S-522)

Merge branch 'develop' of github.com:topcoder-platform/identity-api-v…

8aa84a5

…6 into develop

Merge pull request #26 from topcoder-platform/PM-3576_m2m-token-fix

7b2427a

PM-3576 - use auth0 proxy for token caching

kkartunov requested review from Copilot and jmgasper February 3, 2026 08:07

github-actions bot reviewed Feb 3, 2026

View reviewed changes

Copilot started reviewing on behalf of kkartunov February 3, 2026 08:08 View session

github-actions bot reviewed Feb 3, 2026

View reviewed changes

kkartunov requested a review from vas3a February 3, 2026 08:11

Copilot AI reviewed Feb 3, 2026

View reviewed changes

jmgasper merged commit 1b34a83 into master Feb 5, 2026
14 of 15 checks passed

		@@ -0,0 +1 @@
		export * from "./index" No newline at end of file

		@@ -0,0 +1 @@
		export * from "./default" No newline at end of file

	"value": "/Users/hentrymartin/development/identity-api-v6/packages/identity-prisma-client",
	"value": __dirname,

		if (typeof globalThis !== 'undefined' && globalThis['DEBUG'] \|\| typeof process !== 'undefined' && process.env && process.env.DEBUG \|\| undefined) {
		Debug.enable(typeof globalThis !== 'undefined' && globalThis['DEBUG'] \|\| typeof process !== 'undefined' && process.env && process.env.DEBUG \|\| undefined)

Conversation

kkartunov commented Feb 3, 2026

Uh oh!

github-actions bot Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants