Conversation
Fixed CSS style issue
PS-423 - fix retUrl in gigs modal
PS-412 - replace taas email
| } = props; | ||
| let retUrl; | ||
| // eslint-disable-next-line no-restricted-globals | ||
| const retUrl = isomorphy.isClientSide() ? location.href : null; |
There was a problem hiding this comment.
[❗❗ security]
Using location.href directly can lead to security issues, such as open redirects, if not handled carefully. Consider using a safer method to construct URLs or validate the URL before use.
| color: $tc-orange; | ||
| } | ||
|
|
||
| .data-science-accent-color { |
There was a problem hiding this comment.
[maintainability]
The addition of .data-science-accent-color seems redundant since it duplicates the existing .datasci-accent-color with the same style. Consider removing one to avoid unnecessary duplication, which can lead to maintenance challenges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PS-412
https://topcoder.atlassian.net/browse/PS-423
https://topcoder.atlassian.net/browse/PS-411