Fix GA_KEY_CONTENT OpenSSL crypto error#44
Open
kleberbaum wants to merge 1 commit intotomdyson:masterfrom
Open
Fix GA_KEY_CONTENT OpenSSL crypto error#44kleberbaum wants to merge 1 commit intotomdyson:masterfrom
kleberbaum wants to merge 1 commit intotomdyson:masterfrom
Conversation
OpenSSL.crypto.load_privatekey can't detect start line due to a
str.replace() for '\n' and '\r'.
json.loads() can't handle '\n' and '\r' cause it thinks they are
control character.
Therefore '\n' and '\r' have to be double escape rather than deleted.
OpenSSL.crypto.load_privatekey() can't handle '\r' either,
so a private_key with '\r' wouldn't work anyway. ¯\_(ツ)_/¯
Error:
OpenSSL.crypto.Error: [('PEM routines', 'get_name', 'no start line')]
Ref:
tomdyson#25
https://stackoverflow.com/a/45571017
cspollar
added a commit
to CCITatBCM/wagalytics
that referenced
this pull request
Jun 29, 2020
|
When will this be merged? EDIT: |
diogosilva30
added a commit
to diogosilva30/wagalytics
that referenced
this pull request
Oct 2, 2021
Forked because original maintainer is not review pull requests This is the change proposed in: tomdyson#44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior? (link to any open issues here)
What is the new behavior (if this is a feature change)?
Other information:
I wasn't able to get it working without my fix.