feat: integrate superpowers skills into dev-workflow plugin#6
Merged
Conversation
Add TDD skill enforcing red-green-refactor cycle with verification checkpoints. Establishes iron law: no production code without failing test first. Integrates with systematic-debugging for regression tests and implementer for disciplined implementation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Implements 4-phase debugging framework (Investigate -> Analyze -> Hypothesize -> Implement) with iron law of no fixes without root cause. Key features: - Structured evidence gathering and hypothesis testing - 3-fix rule to prevent infinite fix loops - Chains to test-driven-development for fix implementation - Clear checkpoints and success criteria - Integration with implementer and subagent workflows Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Creates isolated worktrees for feature branches to prevent git index conflicts during parallel development. Provides smart directory selection, safety verification, and cleanup guidance. Key features: - Safety checks before worktree creation - Sibling directory naming pattern - Chains to writing-plans for implementation - Comprehensive cleanup process - Common commands reference Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Implements Socratic dialogue approach for requirements exploration: - One question at a time with multiple choice options - Incremental design building with 200-300 word validated sections - Saves to docs/plans/YYYY-MM-DD-<topic>-design.md - Chains to using-git-worktrees and writing-plans Key principles: - No lists of questions (reduces user burden) - Validate each section before continuing - Build understanding incrementally through dialogue - Clear integration with downstream skills Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Creates bite-sized tasks with model recommendations - Embeds TDD approach in task structure - Plan header references dev-workflow:subagent-driven-development - Includes comprehensive examples and anti-patterns - Model selection guide (haiku/sonnet/opus) - Phase boundary review checkpoints Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Change superpowers:writing-plans to dev-workflow:writing-plans - Add references to dev-workflow:brainstorming - Add references to dev-workflow:systematic-debugging - Add references to dev-workflow:test-driven-development - Add references to dev-workflow:using-git-worktrees Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ic-debugging Add mentions of dev-workflow:brainstorming for features and dev-workflow:systematic-debugging for bugs in SessionStart hook context. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace hardcoded 12-second sleep with gh pr checks --watch flag to properly wait for all CI checks to complete before proceeding with comment review. Also reduce post-CI delay to 5 seconds since watch already waits for completion. - commands/pr-merge.md: Add --watch flag after initial check status query - agents/pr-verifier.md: Add watch step and reduce sleep to 5 seconds
Replace arbitrary 5-second sleep with active polling that waits up to 60 seconds for the Claude code review comment. The review comment is REQUIRED before proceeding with merge evaluation. Changes: - commands/pr-merge.md: Poll for review comment with 12 retries (60s total) - agents/pr-verifier.md: Same polling logic, block if comment not found - Search for bot usernames: claude, code-review, github-actions - Exit with warning if comment not found after polling Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix jq Cartesian product bug in comment polling (pr-merge.md, pr-verifier.md) - Revert version to 2.1.0 (will use release automation for versioning) - Update README to reflect polling behavior instead of fixed wait time Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Claude finished @tombakerjr's task in 1m 42s —— View job Code Review Complete
LGTM - no blocking issues Reviewed this comprehensive integration of 5 workflow skills from superpowers into dev-workflow. The changes are well-structured and self-contained: Verified
Notable improvements in this PR
No security issues, logic errors, or missing error handling detected. Test plan in PR description is appropriate. |
- Fix plugin.json URLs to use actual repo name (claude-code-pr-workflow) - Simplify workflow-preferences.sh messaging - Update README install commands to use dev-workflow plugin name Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates planning and workflow skills from superpowers into dev-workflow, creating a self-contained development workflow plugin.
New Skills (5 created)
test-driven-developmentsystematic-debuggingwriting-plansusing-git-worktreesbrainstormingSkill Chaining
Other Changes
gh pr checks --watch+ polls for Claude review commentSelf-Contained
All
superpowers:references removed. Plugin is now fully self-contained.Test plan
claude plugin updatedev-workflow:brainstormingloads correctlydev-workflow:systematic-debuggingloads correctly🤖 Generated with Claude Code