Conversation
arzarian
reviewed
Mar 23, 2026
arzarian
reviewed
Mar 23, 2026
arzarian
reviewed
Mar 23, 2026
| )->toArray(); | ||
| } | ||
|
|
||
| public function describeMethod(): void |
There was a problem hiding this comment.
Для чего эти методы? По МРу они вызываются все подряд. Точно ли нужно их дробить на разные методы?
Author
There was a problem hiding this comment.
так кажется наглядней и понятней чем всё в одном методе.
There was a problem hiding this comment.
Прост публичные методы говорят о том, что их можно вызвать где угодно и они что-то сделают, а тут они должны идти подряд и вместе. Мб сделать их protected и один public метод, который их вызывает. И наглядность, и нет возможности вызвать иначе
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.