feat(mcp): unified MCP client with prompts, caching, retry, batch, REPL, metrics, and auto-routing#140
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive Model Context Protocol (MCP) client integration and an execution observation tracking system. It adds a new mcp client CLI for discovering and calling tools on external servers via stdio or HTTP, alongside an interactive REPL and a registry for managing multiple connections with retry logic. Additionally, it implements an observations command to monitor resource usage (RAM, VRAM, wall time) and updates the doctor command with MCP configuration validation. Review feedback highlights the need to use command contexts for proper cancellation, fix a typo in a flag default, and resolve input parsing bugs in the REPL where arguments with spaces were truncated. Suggestions were also made to refactor duplicate tool-calling logic and adopt more reliable patterns for identifying transient HTTP errors.
toasterbook88
pushed a commit
that referenced
this pull request
May 25, 2026
- Replace context.Background() with cmd.Context() in all runMCPClient* functions - Fix --format flag default typo (format → text) - Fix REPL arg parsing for call/get-prompt to join remaining args with spaces - Fix REPL search to use full multi-word keyword - Refactor isTransientError to use errors.As with httpStatusCoder instead of fragile string matching - Extract shared callTool internal method to deduplicate CallTool and CallToolWithProgress - Update mcp_client_test.go to pass context.Context Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
toasterbook88
force-pushed
the
obs-surface-and-cli
branch
from
8256910 to
61447d1
Compare
toasterbook88
pushed a commit
that referenced
this pull request
May 25, 2026
- Replace context.Background() with cmd.Context() in all runMCPClient* functions - Fix --format flag default typo (format → text) - Fix REPL arg parsing for call/get-prompt to join remaining args with spaces - Fix REPL search to use full multi-word keyword - Refactor isTransientError to use errors.As with httpStatusCoder instead of fragile string matching - Extract shared callTool internal method to deduplicate CallTool and CallToolWithProgress - Update mcp_client_test.go to pass context.Context Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
toasterbook88
force-pushed
the
obs-surface-and-cli
branch
from
61447d1 to
d8900ec
Compare
…PL, metrics, and auto-routing Implements a comprehensive axis mcp client subcommand suite: Operator UX: - axis mcp client prompts / get-prompt for prompt discovery - --pretty flag for human-readable JSON output on call/read - axis mcp client search <keyword> for tool discovery - axis doctor validates MCP server configs (stdio command existence, HTTP URL) Reliability: - Per-connection caching (60s TTL) with sync.RWMutex - Retry with exponential backoff (3 attempts, 200ms start) for transient errors - axis mcp client batch <file.json> for sequential multi-tool execution Advanced Surfaces: - Interactive REPL (axis mcp client interactive) with 10 commands - Per-server metrics surfaced in list --format json Intelligence: - Placement-aware routing (--auto-route) tries all servers offering a tool - Progress notification infrastructure (CallToolWithProgress, SetProgressHandler) Quality gates: lint, test-race, coverage, build all pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fixes TestMeshPartitionCoalescing by properly handling pending triggers during refresh completion. The original logic had a race condition where pending triggers weren't properly counted when completing a refresh. Changes: - Record start time when winning the refresh lock for latency fallback - Capture pending state before clearing it - Use captured pending triggers for next trigger determination - Fix activeRequestedAt assignment logic
- Replace context.Background() with cmd.Context() in all runMCPClient* functions - Fix --format flag default typo (format → text) - Fix REPL arg parsing for call/get-prompt to join remaining args with spaces - Fix REPL search to use full multi-word keyword - Refactor isTransientError to use errors.As with httpStatusCoder instead of fragile string matching - Extract shared callTool internal method to deduplicate CallTool and CallToolWithProgress - Update mcp_client_test.go to pass context.Context Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…leanup Add a 100ms grace period at the end of the test to allow any lingering background goroutines from prior watch-config tests to finish file operations before t.TempDir() cleanup runs. The failure was an unlinkat ... directory not empty caused by doRefresh writes racing with RemoveAll. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
toasterbook88
force-pushed
the
obs-surface-and-cli
branch
from
b665d95 to
0fc79ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a comprehensive MCP client to the axis CLI, implementing 11 out of 12 planned improvements (with daemon integration deferred). Features include:
All quality checks pass.