Conversation
tony
added a commit
that referenced
this pull request
Mar 7, 2026
why: Document the three new features for the upcoming release. what: - Pane.set_title() and pane_title support - Configurable tmux binary path (Server tmux_bin parameter) - Pre-execution command logging in tmux_cmd
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #636 +/- ##
==========================================
+ Coverage 45.48% 45.60% +0.11%
==========================================
Files 22 22
Lines 2260 2274 +14
Branches 361 362 +1
==========================================
+ Hits 1028 1037 +9
- Misses 1085 1089 +4
- Partials 147 148 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
why: tmux_cmd logs stdout after execution and exceptions, but never logs the command before execution. Pre-execution logging is the prerequisite for a future dry-run mode in tmuxp (tmuxinator's debug / teamocil's --debug equivalent). what: - Add logger.debug call before subprocess.Popen in tmux_cmd.__init__ - Add test verifying pre-execution log message contains command
why: tmux supports select-pane -T and #{pane_title} (since 2.6).
tmuxinator uses this for named panes. libtmux had no wrapper and
pane_title was commented out of formats.py.
what:
- Uncomment pane_title in formats.py PANE_FORMATS list
- Add pane_title field to neo.Obj dataclass
- Add Pane.set_title() method using select-pane -T
- Add Pane.title property alias for pane_title
- Add tests for set_title with plain and special characters
why: shutil.which("tmux") is hardcoded in tmux_cmd and Server. No way
to use wemux, byobu, or a custom-built tmux. tmuxinator supports
tmux_command config key including wemux module.
what:
- Add tmux_bin keyword arg to tmux_cmd.__init__ (backward compatible)
- Add tmux_bin parameter to Server.__init__ with pathlib.Path support
- Thread tmux_bin through Server.cmd(), Server.raise_if_dead(), and
neo.fetch_objs()
- Session/Window/Pane inherit via server.cmd() delegation
- Add tests for default, custom path, and invalid path scenarios
why: Document the three new features for the upcoming release. what: - Pane.set_title() and pane_title support - Configurable tmux binary path (Server tmux_bin parameter) - Pre-execution command logging in tmux_cmd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three non-breaking API additions to support tmuxp's feature parity with tmuxinator (3.3.7) and teamocil (1.4.2).
Closes #635. Tracking: tmux-python/tmuxp#1016
tmux_cmdnow logs the command before execution vialogger.debug, enabling future dry-run mode in tmuxp (tmuxinator'sdebug/ teamocil's--debug)Pane.set_title(): Wrapsselect-pane -Tand enablespane_titleformat variable. Uncommentspane_titleinformats.py, adds field toneo.Obj, addsPane.set_title()method andPane.titleproperty aliasServer(tmux_bin="/path/to/tmux")threads throughServer.cmd(),Server.raise_if_dead(), andneo.fetch_objs(). Supports wemux, byobu, or custom-built tmux binaries (tmuxinator'stmux_commandequivalent)All changes are fully backward-compatible — new parameters default to existing behavior.
Test plan
test_tmux_cmd_pre_execution_logging)set_titlewith plain text and special characterstmux_bindefault, custom path, and invalid pathPane.set_title()andPane.title