PR 2: Remove --dangerous-skip-interactive, use global --no-input for non-interactive approval#113
Closed
natefikru wants to merge 4 commits intonate/tvc-non-interactive-loginfrom
Closed
Conversation
natefikru
force-pushed
the
nate/tvc-non-interactive-approve
branch
4 times, most recently
from
bdc6824 to
61e502e
Compare
natefikru
force-pushed
the
nate/tvc-non-interactive-approve
branch
from
3a0d588 to
1f2df1a
Compare
natefikru
changed the title
Author
|
Merged into PR #112 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on PR 1 (#112).
--dangerous-skip-interactiveflag fromdeploy approve--no-inputflag (from PR 1) to skip interactive manifest approval prompts--dangerous-skip-interactivemust switch to--no-inputTest plan
cargo test --test deploy_approve(6 tests: non-interactive skip, interactive prompts, reject, error cases)cargo test --test global_flags(2 tests: flag recognition)cargo clippy --all-targets --all-features -- -D warningstvc --no-input deploy approve --manifest <path> --skip-postskips prompts and outputs JSONtvc deploy approve --manifest <path>still shows interactive prompts