Skip to content

Migrate VspHelper to use MasmAddr #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthew-mojira wants to merge 2 commits into
base: master
Choose a base branch
from
+480 −349
Open

Migrate VspHelper to use MasmAddr #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
142750e
[WIP] Migrate VspHelper to use MasmAddr
matthew-mojira Jan 29, 2026
db2c66a
Fix failing tests in VspHelper update
matthew-mojira Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/engine/compiler/MacroAssembler.v3
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@ class MacroAssembler(valuerep: Tagging, regConfig: RegConfig) {

def emit_binop_r_r(op: Opcode, reg: Reg, reg2: Reg);
def emit_binop_r_m(op: Opcode, reg: Reg, addr: MasmAddr);
def emit_binop_m_r(op: Opcode, addr: MasmAddr, reg: Reg);
def emit_binop_r_i(op: Opcode, reg: Reg, val: int);

def emit_pop_r(kind: ValueKind, reg: Reg);
Expand Down
8 changes: 6 additions & 2 deletions src/engine/compiler/RegSet.v3
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@

// Architecture-independent representation of a register for use in {MacroAssembler} and portable
// parts of compilers. Kept small to keep data structures small. The name is stored in a {RegSet}.
type Reg(index: byte) #unboxed { }
type Reg(index: byte) #unboxed {
def plus(offset: int) -> MasmAddr {
return MasmAddr(this, offset);
}
}

// Describes the set of (maximum 256) registers for a target.
// By convention, register #0 is reserved for indicating an unallocated register or no register.
Expand Down Expand Up @@ -49,4 +53,4 @@ class RegPool32(regs: Array<Reg>) {
map = Array<u5>.new(max + 1);
for (i < regs.length) map[regs[i].index] = u5.!(i);
}
}
}
Loading