fix(linux): include libxdo3 in deb dependencies#2498
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds ChangesAdd libxdo3 system dependency
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
libxdo3to the Tauri desktop.debdependency list so Debian installs pull in the runtime library that provideslibxdo.so.3.tauri.conf.jsonpackage config and assertlibxdo3is present exactly once.Why
Refs #2497. The standalone CLI package template already declares
libxdo3, but the desktop Tauri.debconfig did not. Users installing the desktop.debcan therefore launch intoerror while loading shared libraries: libxdo.so.3.Validation
app/src-tauri/tauri.conf.jsonwith Node and asserted the expected Debian deps includelibxdo3exactly once.cargo fmt --manifest-path Cargo.toml --all --checkgit diff --check -- app/src-tauri/tauri.conf.json tests/linux_cef_deb_runtime_e2e.rsAttempted:
cargo test --test linux_cef_deb_runtime_e2e debian_package_dependencies_configuredmsvcrt.lib(LNK1104).Note:
git pushtriggered the repo pre-push hook, which auto-ran full app Prettier over pre-existing formatting drift and then failed on unrelated existing lint issues. I pushed with hooks skipped after confirming the scoped validation above.Summary by CodeRabbit