Skip to content

Fix KPI hourly granularity with previous period #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnzjgo merged 1 commit into from
Feb 12, 2026
Merged

Fix KPI hourly granularity with previous period #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tinybird/fixtures/analytics_events.ndjson
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{"timestamp":"2026-02-10 10:10:00","session_id":"session-yesterday-1","action":"page_hit","version":"v1","payload":"{\"domain\":\"example.com\",\"location\":\"US\",\"referrer\":\"https://google.com\",\"pathname\":\"/\",\"href\":\"https://example.com/\",\"user-agent\":\"Mozilla/5.0 (Macintosh; Intel Mac OS X) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0 Safari/537.36\"}","tenant_id":"test-tenant","domain":"example.com"}
{"timestamp":"2026-02-10 11:45:00","session_id":"session-yesterday-2","action":"page_hit","version":"v1","payload":"{\"domain\":\"example.com\",\"location\":\"US\",\"referrer\":\"https://google.com\",\"pathname\":\"/pricing\",\"href\":\"https://example.com/pricing\",\"user-agent\":\"Mozilla/5.0 (Macintosh; Intel Mac OS X) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0 Safari/537.36\"}","tenant_id":"test-tenant","domain":"example.com"}
{"timestamp":"2026-02-11 10:15:00","session_id":"session-today-1","action":"page_hit","version":"v1","payload":"{\"domain\":\"example.com\",\"location\":\"US\",\"referrer\":\"https://news.ycombinator.com\",\"pathname\":\"/\",\"href\":\"https://example.com/\",\"user-agent\":\"Mozilla/5.0 (Macintosh; Intel Mac OS X) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0 Safari/537.36\"}","tenant_id":"test-tenant","domain":"example.com"}
{"timestamp":"2026-02-11 11:20:00","session_id":"session-today-2","action":"page_hit","version":"v1","payload":"{\"domain\":\"example.com\",\"location\":\"US\",\"referrer\":\"https://news.ycombinator.com\",\"pathname\":\"/docs\",\"href\":\"https://example.com/docs\",\"user-agent\":\"Mozilla/5.0 (Macintosh; Intel Mac OS X) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0 Safari/537.36\"}","tenant_id":"test-tenant","domain":"example.com"}
3 changes: 2 additions & 1 deletion tinybird/src/endpoints.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,8 @@ export const kpis = defineEndpoint("kpis", {
FROM timeseries a
LEFT JOIN current_period_data b ON a.date = b.date
LEFT JOIN previous_period_data p ON a.date = timestampAdd(p.date, interval (SELECT period_days FROM date_calculations) day)
WHERE a.date >= (SELECT current_start FROM date_calculations) AND a.date <= (SELECT current_end FROM date_calculations)
WHERE a.date >= (SELECT current_start FROM date_calculations)
AND a.date <= timestampAdd((SELECT current_end FROM date_calculations), interval 1 day)
{% else %}
SELECT
a.date date,
Expand Down