Skip to content

feat: bump MIN_TCB_EVALUATION_DATA_NUMBER and use collateral proxy#70

Merged
jdrean merged 2 commits intomainfrom
jules/collateral
Mar 31, 2026
Merged

feat: bump MIN_TCB_EVALUATION_DATA_NUMBER and use collateral proxy#70
jdrean merged 2 commits intomainfrom
jules/collateral

Conversation

@jdrean
Copy link
Copy Markdown
Member

@jdrean jdrean commented Mar 30, 2026

Summary by cubic

Route Intel PCS collateral requests through our TDX collateral proxy, bump the minimum TCB evaluation data number to 19, and re-fetch cached entries below the threshold. This ensures fresher TDX collateral and more reliable fetches.

  • New Features

    • Added _proxy_url and route all collateral HTTP GETs via tdx-proxy.tinfoil.sh.
    • Set DEFAULT_MIN_TCB_EVALUATION_DATA_NUMBER to 19 and pass it via tcbEvaluationDataNumber to TCB Info and QE Identity requests.
  • Bug Fixes

    • Cache now re-fetches when cached TCB Info or QE Identity has tcbEvaluationDataNumber below the threshold.

Written for commit f6c7128. Summary will update on new commits.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/tinfoil/attestation/collateral_tdx.py">

<violation number="1" location="src/tinfoil/attestation/collateral_tdx.py:390">
P1: Bumping the minimum TCB evaluation number without cache-version invalidation can cause persistent validation failures on fresh-but-now-too-old cached collateral.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

@jdrean jdrean merged commit e3d1035 into main Mar 31, 2026
2 checks passed
@jdrean jdrean deleted the jules/collateral branch March 31, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant