feat: bump MIN_TCB_EVALUATION_DATA_NUMBER and use collateral proxy#70
Merged
feat: bump MIN_TCB_EVALUATION_DATA_NUMBER and use collateral proxy#70
Conversation
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/tinfoil/attestation/collateral_tdx.py">
<violation number="1" location="src/tinfoil/attestation/collateral_tdx.py:390">
P1: Bumping the minimum TCB evaluation number without cache-version invalidation can cause persistent validation failures on fresh-but-now-too-old cached collateral.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Route Intel PCS collateral requests through our TDX collateral proxy, bump the minimum TCB evaluation data number to 19, and re-fetch cached entries below the threshold. This ensures fresher TDX collateral and more reliable fetches.
New Features
_proxy_urland route all collateral HTTP GETs viatdx-proxy.tinfoil.sh.DEFAULT_MIN_TCB_EVALUATION_DATA_NUMBERto 19 and pass it viatcbEvaluationDataNumberto TCB Info and QE Identity requests.Bug Fixes
Written for commit f6c7128. Summary will update on new commits.