test(config): isolate tests from PG* env#43
Merged
Conversation
…Fields from PG* env config.go intentionally binds PGHOST/PGPORT/PGUSER/PGDATABASE/PGPASSWORD via viper.BindEnv (the production-correct behavior). But these two tests assert default config values without isolating from the ambient shell environment, so they fail on any developer machine that has those vars exported -- a common setup for talking to a password-auth PostgreSQL like the demo container. Add a small unsetPostgreSQLEnvVars(t) helper that unsets the five PG* vars for the test and restores their originals via t.Cleanup, and call it at the top of the two affected tests. The production binding behavior is unchanged. CI behavior (no PG* env) is unchanged. The existing TestConfig_PostgreSQLEnvVars test (which deliberately sets PG* vars and asserts they flow into config) remains untouched. Before: 2 failed when PGHOST/PGPORT/PGUSER/PGDATABASE/PGPASSWORD exported. After: full config package green under both env conditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestInit_SetsDefaults and TestConfig_ConnectionFields:
config.go intentionally binds PGHOST/PGPORT/PGUSER/PGDATABASE/PGPASSWORD via viper.BindEnv (the production-correct behavior). But these two tests assert default config values without isolating from the ambient shell environment, so they fail on any developer machine that has those vars exported -- a common setup for talking to a password-auth PostgreSQL like the demo container.
Add a small unsetPostgreSQLEnvVars(t) helper that unsets the five PG* vars for the test and restores their originals via t.Cleanup, and call it at the top of the two affected tests.
The production binding behavior is unchanged. CI behavior (no PG* env) is unchanged. The existing TestConfig_PostgreSQLEnvVars test (which deliberately sets PG* vars and asserts they flow into config) remains untouched.
Before: 2 failed when PGHOST/PGPORT/PGUSER/PGDATABASE/PGPASSWORD exported.
After: full config package green under both env conditions.