fix(db): populated URL in getTestConnectionString to fix password injection#42
Merged
Conversation
…rd injection NewClient's injectPasswordIntoConnStr requires user@host in the URL to inject the resolved password (from PGPASSWORD or password_command). getTestConnectionString previously returned the bare URL "postgres://localhost/postgres?sslmode=disable" and relied on pgx's env-var fallback for credentials. This broke whenever PGPASSWORD was set: NewClient errored with "connection string has no user@host format" before any test logic ran, blocking 75 tests in the db package from running against a local PostgreSQL with password auth. Read PGHOST/PGPORT/PGUSER/PGPASSWORD/PGDATABASE and construct a fully-populated URL with url.QueryEscape on credentials. Keep TEST_DATABASE_URL precedence intact for CI/CD environments that supply their own connection string. Add unit tests covering: the populated-URL contract, the no-PGHOST skip path, TEST_DATABASE_URL precedence, and special-character escaping. Before: 75 failed, 0 passed (against demo PG). After: 0 failed, full db suite green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewClient's injectPasswordIntoConnStr requires user@host in the URL to inject the resolved password (from PGPASSWORD or password_command). getTestConnectionString previously returned the bare URL "postgres://localhost/postgres?sslmode=disable" and relied on pgx's env-var fallback for credentials. This broke whenever PGPASSWORD was set: NewClient errored with "connection string has no user@host format" before any test logic ran, blocking 75 tests in the db package from running against a local PostgreSQL with password auth.
Read PGHOST/PGPORT/PGUSER/PGPASSWORD/PGDATABASE and construct a fully-populated URL with url.QueryEscape on credentials. Keep TEST_DATABASE_URL precedence intact for CI/CD environments that supply their own connection string.
Add unit tests covering: the populated-URL contract, the no-PGHOST skip path, TEST_DATABASE_URL precedence, and special-character escaping.
Before: 75 failed, 0 passed (against demo PG).
After: 0 failed, full db suite green.