Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ARG commit_id

FROM python:3.13.3-alpine as base
FROM python:3.14.3-alpine as base
Comment on lines 1 to +3
Copy link

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARG commit_id is never provided by compose.yaml (no build.args), so FOLDERISTIC_COMMIT_ID will be empty in typical docker compose up usage. If this value is required at runtime (e.g., for get_commit_id() fallback), consider wiring the build arg through compose, providing a default, or removing the commit-id plumbing from the image.

Copilot uses AI. Check for mistakes.
RUN python3 -m pip install poetry
RUN python3 -m poetry config virtualenvs.in-project true
FROM base as build
Expand All @@ -10,7 +10,7 @@ RUN apk update
RUN apk add --no-cache make gcc linux-headers build-base
RUN python3 -m poetry install
RUN apk del gcc linux-headers build-base
FROM python:3.13.3-alpine as run
FROM python:3.14.3-alpine as run
ENV FOLDERISTIC_DOCKER = 1
ENV FOLDERISTIC_COMMIT_ID = ${commit_id}
Comment on lines 14 to 15
Copy link

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENV lines use spaces around = (ENV FOLDERISTIC_DOCKER = 1, ENV FOLDERISTIC_COMMIT_ID = ${commit_id}), which Docker treats as part of the value (e.g., value becomes "= 1" / "= "). This can break consumers expecting the raw commit id (e.g., get_commit_id() fallback reads FOLDERISTIC_COMMIT_ID). Use ENV FOLDERISTIC_DOCKER=1 and ENV FOLDERISTIC_COMMIT_ID=${commit_id} (or the ENV key value form without =) to set the intended values.

Suggested change
ENV FOLDERISTIC_DOCKER = 1
ENV FOLDERISTIC_COMMIT_ID = ${commit_id}
ENV FOLDERISTIC_DOCKER=1
ENV FOLDERISTIC_COMMIT_ID=${commit_id}

Copilot uses AI. Check for mistakes.
WORKDIR /folderistic
Expand Down
Loading