Implementation of a POMDP node for classification#1
Open
Hororohoruru wants to merge 17 commits intomainfrom
Open
Implementation of a POMDP node for classification#1Hororohoruru wants to merge 17 commits intomainfrom
Hororohoruru wants to merge 17 commits intomainfrom
Conversation
Member
|
Since POMDP requires to learn from from the training dataset, wouldn't it be better to implement this algorithm as a sklearn estimator? |
Collaborator
Author
|
The POMDP does not learn from the training dataset, like the classification pipeline. Rather, it needs a confusion matrix generated from the trained ML pipeline (which means more total calibration). Even if it has a 'fit' step, the prediction part is not similar to a sklearn estimator, so I would not go in that direction at the moment. We can always revisit the implementation if we see it is more similar to an estimator down the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the PR for the implementation of POMDP as an alternative strategy to output predictions.