Ensure soa![Foo; n] works with n > 2 as intended#42
Open
1Git2Clone wants to merge 1 commit intotim-harding:mainfrom
Open
Ensure soa![Foo; n] works with n > 2 as intended#421Git2Clone wants to merge 1 commit intotim-harding:mainfrom
soa![Foo; n] works with n > 2 as intended#421Git2Clone wants to merge 1 commit intotim-harding:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In regards to #41, I'm providing a simple fix which ensures
soa![Foo; n]works for arrays withnelements by properly incrementing theivariable.I've also provided an optimization for the solution by first reserving
nand changed the test case to use 5 elements instead of 2 in order to make sure that this edge case is covered in the tests.