Generate url with nested query params#175
Draft
snewcomer wants to merge 2 commits intotildeio:masterfrom
Draft
Conversation
snewcomer
force-pushed
the
nested-qps
branch
2 times, most recently
from
a02846d to
877fc19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref emberjs/ember.js#19791
Bug
Nested query params are not serialized into the URL property
Expected
There are some other considerations - generating nested query strings can be done many different ways and exploring a solution requires that we settle on "one" of the ways to ensure we don't go breaking users.
e.g. a nested filter
?filter[make]=honda&filter[model]=civic?filter=[make]=honda&filter=[model]=civic?filter.make=honda&filter.model=civice.g. nested array filter
?a[0]=b&a[1]=c?a[]=b&a[]=c?a=b&a=cNote - libraries like qs have taken stances on certain patterns. We can glean what to do from them but in no means is it the "correct" way.