Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8ffded32c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| request_body_json = """ | ||
|
|
||
| request_loaded_json = json.loads(request_body_json) |
There was a problem hiding this comment.
The test_set_generic_connector_operations_models_validation function starts request_body_json with """ and never closes it before subsequent Python statements, which causes an IndentationError when the module is imported (observed at the next indented JSON block). In practice, running pytest for the connectors package will fail during test collection, so this generated test suite is unusable until the request payload string is properly terminated (or replaced with valid JSON like []).
Useful? React with 👍 / 👎.
| request_body_json = """ | ||
|
|
||
| request_loaded_json = json.loads(request_body_json) |
There was a problem hiding this comment.
The test_set_operation_connectors_models_validation test has the same unterminated request_body_json triple-quoted string, so Python treats following lines as part of the string and then errors at the next indented JSON object. This breaks import/collection of the test module, meaning connectors tests cannot run until the request body string is closed and valid JSON is provided.
Useful? React with 👍 / 👎.
|
superseded by #143 |
2 participants
No description provided.