Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a32e1e033
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| def test_set_operation_connectors_models_validation(self) -> None: | ||
| """Test case for set_operation_connectors request and response models""" | ||
| request_body_json = """ |
There was a problem hiding this comment.
The request_body_json assignment opens a triple-quoted string but never closes it before the next statements, which makes this test module fail to parse (IndentationError during pytest collection). As a result, running tests for the new connectors package stops before execution in any environment that imports this file.
Useful? React with 👍 / 👎.
|
|
||
| def test_set_generic_connector_operations_models_validation(self) -> None: | ||
| """Test case for set_generic_connector_operations request and response models""" | ||
| request_body_json = """ |
There was a problem hiding this comment.
This test has the same unterminated triple-quoted request_body_json assignment, so Python cannot parse the file and pytest collection fails before any tests run. That makes the generated connectors test suite unusable until the string is properly closed.
Useful? React with 👍 / 👎.
| request_body_json = """ | ||
|
|
||
| request_loaded_json = json.loads(request_body_json) | ||
| request_from_json = thousandeyes_sdk.connectors.models.List[str].from_json(request_body_json) |
There was a problem hiding this comment.
thousandeyes_sdk.connectors.models only exports schema classes, not a List model type, so this call raises AttributeError once parsing issues are fixed. That means request-model validation for this endpoint still fails at runtime even after syntax errors are addressed.
Useful? React with 👍 / 👎.
|
superseded by #143 |
2 participants
No description provided.