Fix release workflow: add workflow_dispatch, environment, and .tool-versions#1818
Merged
neilvcarvalho merged 2 commits intomainfrom May 4, 2026
Merged
Fix release workflow: add workflow_dispatch, environment, and .tool-versions#1818neilvcarvalho merged 2 commits intomainfrom
neilvcarvalho merged 2 commits intomainfrom
Conversation
Replaces hardcoded ruby-version values in setup-ruby steps with .tool-versions so the Ruby version is defined in one place. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds workflow_dispatch so a release can be triggered without bumping version.rb. Also runs the job in the "release" GitHub Actions environment for environment-scoped secrets and required reviewers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_dispatchto the release workflow so a release can be triggered manually without needing to bumplib/factory_bot/version.rbreleaseGitHub Actions environment, enabling environment-scoped secrets and optional required reviewers.tool-versionsfile (Ruby 4.0) and removes hardcodedruby-versionvalues fromsetup-rubysteps inrelease.yml,prepare-release.yml, and thestandardjob inbuild.yml— the version is now defined in one placeThe
buildmatrix job is unchanged since it iterates over explicit Ruby versions by design.Test plan
.tool-versionscorrectly