Add localized time formatting and update customer dashboard example#2780
Merged
Merged
Conversation
goosys
force-pushed
the
2702-refactor-time-format
branch
from
805cde3 to
2000027
Compare
This ensures consistency across public methods for `DateTime`, `Date`, and `Time` which all had slight differences. `Field::Time#time` now always goes through `I18n.localize`, previously if the `format` option wasn't specified, it bypassed `translate_localization_format` and so AM/PM was not localized. There's now an example on `Customer` so that we can see the behaviour.
nickcharlton
force-pushed
the
2702-refactor-time-format
branch
from
2000027 to
876a250
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field::Time#timeto always go throughI18n.localize:formatoption wasn’t specified, it bypassedtranslate_localization_format, so AM/PM was not localized.Customer.example_timeto the Dashboard in the example app to check the behavior of theField::Time.rails-i18ngem, we don’t have to worry about am/pm translations being undefined.