Draft
Conversation
added 2 commits
October 16, 2024 21:17
Collaborator
|
This sounds like a great solution! I’ll update to the new branch asap. |
timothyfaris
approved these changes
Oct 17, 2024
Owner
Author
|
@timothyfaris I think the only potential case that is not covered are temperature readings that "appear" valid but are not. I think we have both experienced the case where the sensor reads the same value that is below the set-point continuously, which leads to overheating. In this case there is no exception raised so I may need to find an alternative route for identifying "anomalous" temperature readings to prevent this type of overheating. Let's see what we run into over the coming weeks! |
added 10 commits
October 18, 2024 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #30
@timothyfaris Hey! I implemented a few changes yesterday to hopefully resolve the occasional overheating issue. These changes cover all our previous hypotheses, that either the overheating could be caused by,
The primary change to highlight is that the temp-pid controller now raises an error code when exceptions occur when reading temperature values. This means that when an exception occurs, the active controller process will be killed. When killed, the main application will automatically start the temp-pid controller as a new process. Instead of handling the exceptions within the process as before, the application now handles the exceptions outside the process.
If you would like to try out these changes, you can clone the feature branch, v0.1.1#30. Rerun
steps 8, 11 and 12within the README.md, but onstep 8, instead of cloning the main branch, run the following command,Remember to run
step 12to install the Python packages since I did add a new dependency that you will need to install.Let's plan to use this version of the application for the next few weeks to observe whether either of us encounter the overheating issue still. If not, then I will clean-up the changes and we can move forward with the merge request.