Skip to content

v0.1.1#30#38

Draft
thomaseleff wants to merge 13 commits intov0.1.1from
v0.1.1#30
Draft

v0.1.1#30#38
thomaseleff wants to merge 13 commits intov0.1.1from
v0.1.1#30

Conversation

@thomaseleff
Copy link
Copy Markdown
Owner

Resolves #30

@timothyfaris Hey! I implemented a few changes yesterday to hopefully resolve the occasional overheating issue. These changes cover all our previous hypotheses, that either the overheating could be caused by,

  • Handling of exceptions when reading temperature values, or
  • Memory issues that are handled poorly within the temperature sensor libraries that interface with the hardware chips.

The primary change to highlight is that the temp-pid controller now raises an error code when exceptions occur when reading temperature values. This means that when an exception occurs, the active controller process will be killed. When killed, the main application will automatically start the temp-pid controller as a new process. Instead of handling the exceptions within the process as before, the application now handles the exceptions outside the process.

If you would like to try out these changes, you can clone the feature branch, v0.1.1#30. Rerun steps 8, 11 and 12 within the README.md, but on step 8, instead of cloning the main branch, run the following command,

git clone --branch v0.1.1#30 https://github.com/thomaseleff/Ospro.git

Remember to run step 12 to install the Python packages since I did add a new dependency that you will need to install.

Let's plan to use this version of the application for the next few weeks to observe whether either of us encounter the overheating issue still. If not, then I will clean-up the changes and we can move forward with the merge request.

@thomaseleff thomaseleff added bug Something isn't working v0.1.1 draft labels Oct 17, 2024
@thomaseleff thomaseleff self-assigned this Oct 17, 2024
@thomaseleff thomaseleff marked this pull request as draft October 17, 2024 12:52
@timothyfaris
Copy link
Copy Markdown
Collaborator

This sounds like a great solution! I’ll update to the new branch asap.

@thomaseleff
Copy link
Copy Markdown
Owner Author

@timothyfaris I think the only potential case that is not covered are temperature readings that "appear" valid but are not. I think we have both experienced the case where the sensor reads the same value that is below the set-point continuously, which leads to overheating. In this case there is no exception raised so I may need to find an alternative route for identifying "anomalous" temperature readings to prevent this type of overheating. Let's see what we run into over the coming weeks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working draft v0.1.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants