allow using extra buttons on disabled devices#12
Open
joukhaha wants to merge 3 commits intothjaeger:masterfrom
Open
allow using extra buttons on disabled devices#12joukhaha wants to merge 3 commits intothjaeger:masterfrom
joukhaha wants to merge 3 commits intothjaeger:masterfrom
Conversation
added 3 commits
February 16, 2019 15:47
… devices, and faking the last extra button of a disabled device as the default button. The basic idea is to allow using button 1 for touch screens but still allow disabling mouse gestures for button 1, but still allow default gestures with another mouse button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would someone else have use for the possibility to assign the default button differently for different devices?
As a workaround, I tested enabling the grabbing for the additional buttons of disabled devices, and made the last additional button of a disabled device behave as the default button. In this PR this feature is enabled if the -e flag is used to start easystroke, without -e it should be identical to the original.
The basic need behind this is to allow using button 1 for touch screens, while disabling button 1 for mouse, but still allowing default gestures with another mouse button. The added patch is included for archival purposes. The present version is obviously a hack which should be eventually reworked so that it integrates with the preference etc, if there's sufficient need for it.