Skip to content

fix: don't retry http server 500/501 errors when uploading files#4054

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-skip-retrying-500-server-errors
Mar 17, 2026
Merged

fix: don't retry http server 500/501 errors when uploading files#4054
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-skip-retrying-500-server-errors

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

Proposed changes

When uploading files, treat server errors (status codes, 500 and 501) as non-transient errors so they aren't retried as generally a retry won't help. Status Codes 502/503 are still retried as before as generally these errors are transient.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3374

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller temporarily deployed to Test Pull Request March 16, 2026 22:26 — with GitHub Actions Inactive
@reubenmiller reubenmiller added the theme:configuration Theme: Configuration management label Mar 16, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/common/upload/src/upload.rs 20.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
859 0 3 859 100 2h34m58.842691s

Comment thread crates/common/upload/src/upload.rs
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Mar 17, 2026
Merged via the queue into thin-edge:main with commit dba634e Mar 17, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:configuration Theme: Configuration management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants