feat: warn users about invalid certificate common name for Cumulocity connections#4052
Merged
reubenmiller merged 1 commit intothin-edge:mainfrom Mar 18, 2026
Conversation
Contributor
Robot Results
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
albinsuresh
reviewed
Mar 17, 2026
didier-wenzek
approved these changes
Mar 17, 2026
albinsuresh
approved these changes
Mar 18, 2026
… connections Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
22206de to
0caaef5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Improve the warning for users that have generated the device certificate using external command (e.g. not
tedge cert create). In this scenerio the user doesn't get warning during the cert creation, so they are unaware of the problem.Now the
tedge connect c8ywill display a warning if an invalid Common Name is detected at connection time, though it will not prevent trying to connect to Cumulocity (in case if this restriction is lifted at some point).It is only valid for Cumulocity connections as Cumulocity has a defined list of allowed characters in the Common Name.
Below is an example of the warning that is shown to users:
Types of changes
Paste Link to the issue
#3855
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments