Skip to content

fix: rename tedge config property apt.dpk.options.config to apt.dpkg.options.config#4044

Merged
reubenmiller merged 2 commits intothin-edge:mainfrom
reubenmiller:fix-dpkg-options-config
Mar 18, 2026
Merged

fix: rename tedge config property apt.dpk.options.config to apt.dpkg.options.config#4044
reubenmiller merged 2 commits intothin-edge:mainfrom
reubenmiller:fix-dpkg-options-config

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

Proposed changes

Rename tedge config property apt.dpk.options.config to apt.dpkg.options.config, so that the dpkg related settings are easier for users to find.

The old value is marked as deprecated so it won't break anyones setup, but it will generate a warning marking that the config item has been renamed.

# old name still works
tedge config set apt.dpk.options.config keepold

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#4043

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller temporarily deployed to Test Pull Request March 13, 2026 15:21 — with GitHub Actions Inactive
@reubenmiller reubenmiller added theme:configuration Theme: Configuration management theme:software Theme: Software management and removed theme:software Theme: Software management theme:configuration Theme: Configuration management labels Mar 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 92.38095% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
plugins/tedge_apt_plugin/src/lib.rs 0.00% 8 Missing ⚠️
...dge_config/src/tedge_toml/tedge_config_location.rs 86.27% 0 Missing and 7 partials ⚠️
...edge_config/src/tedge_toml/tedge_config/version.rs 99.33% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 13, 2026

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
851 0 3 851 100 2h43m28.743624999s

@rina23q rina23q temporarily deployed to Test Pull Request March 13, 2026 16:21 — with GitHub Actions Inactive
@reubenmiller reubenmiller added the theme:software Theme: Software management label Mar 13, 2026
Copy link
Copy Markdown
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

Comment thread tests/RobotFramework/tests/tedge/tedge_completions.robot
…kg.options.config`

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
…xisting configurations

Signed-off-by: James Rhodes <jarhodes314@gmail.com>
Copy link
Copy Markdown
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-confirm my approval.

@reubenmiller reubenmiller added this pull request to the merge queue Mar 18, 2026
Merged via the queue into thin-edge:main with commit a15038e Mar 18, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:software Theme: Software management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants