Skip to content

Allow pass headers to KV::put #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kafkiansky merged 1 commit into from
Apr 29, 2026
Merged

Allow pass headers to KV::put #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,9 @@ services:
- .:/workspace:cached
working_dir: /workspace

nats-1:
nats:
image: nats
command: -c /etc/server.conf --name nats-1 -p 4222 -m 8222
volumes:
- ./docker/nats/server.conf:/etc/server.conf

nats-2:
image: nats
command: -c /etc/server.conf --name nats-2 -p 4222 -m 8222
volumes:
- ./docker/nats/server.conf:/etc/server.conf

nats-3:
image: nats
command: -c /etc/server.conf --name nats-3 -p 4222 -m 8222
command: -c /etc/server.conf -p 4222 -m 8222
volumes:
- ./docker/nats/server.conf:/etc/server.conf

Expand Down
9 changes: 0 additions & 9 deletions docker/nats/server.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,3 @@ accounts: {
}

jetstream {}

cluster: {
name: RU,
port: 6222,
routes: [
"nats://nats-1:6222"
"nats://nats-2:6222"
]
}
2 changes: 1 addition & 1 deletion phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
requireCoverageMetadata="true"
>
<php>
<env name="THESIS_NATS_DSN" value="tcp://user:Pswd1@nats-1:4222?no_responders=true" />
<env name="THESIS_NATS_DSN" value="tcp://user:Pswd1@nats:4222?no_responders=true" />
<env name="THESIS_NATS_JWT_DSN" value="tcp://nats-jwt:4222?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJlZDI1NTE5LW5rZXkifQ.eyJqdGkiOiJVT1VSVldRTkpBSUgzSUhBSFRKQ1hOSEFFWTc2RzdXNEtBVlNQRUpZUDNQTTIyWEFDTTJBIiwiaWF0IjoxNzYxMjI0MDE4LCJpc3MiOiJBQlg1TVlTUUpCMlNWUUlXREo2SEZSWkxOM1ZMVzJQRkpOVDNHUDRDTUZHN0xRQ1M1SjM0RUdKSiIsIm5hbWUiOiJ1c2VyX25rZXkiLCJzdWIiOiJVRFBCNlRYV1VRMzNQUkhURjJGSlRQRVJISE43NldIS0VVWURNTEtRWlgyTTZIWUFHUkYySkpTWSIsIm5hdHMiOnsicHViIjp7fSwic3ViIjp7fSwic3VicyI6LTEsImRhdGEiOi0xLCJwYXlsb2FkIjotMSwidHlwZSI6InVzZXIiLCJ2ZXJzaW9uIjoyfX0.4D2PgQMgWzuIhy0LvE0Fy-w84I1AfEdXIb94nrVAkb_s_AdPOoCrQUANsGODLnXb_hel24vo7bATiCUeco1xDQ&amp;nkey=SUADBUTF4FNCHZ7O4BXK35KYAMMDRZFL2DOXCNRGHLQOC5HPJB6TOCTDCQ" />
</php>

Expand Down
4 changes: 2 additions & 2 deletions src/JetStream/KeyValue/Bucket.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,10 @@ public function get(string $key, int $revision = 0): ?Entry
* @param non-empty-string $key
* @return non-negative-int
*/
public function put(string $key, ?string $value = null): int
public function put(string $key, ?string $value = null, ?Headers $headers = null): int
{
return $this->js
->publish($this->prefixedSubject($key), new Message($value))
->publish($this->prefixedSubject($key), new Message($value, $headers))
->seq ?? throw new \LogicException('Sequence expected on kv publish');
}

Expand Down
Loading