feat: enhance GORMCache functionality with transaction support#4
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds transaction support to the GORMCache implementation, allowing cache operations to participate in database transactions. The changes enable transactional cache operations that can be committed or rolled back atomically with other database operations.
Key changes:
- Added context-based transaction support with
WithGORMTxandGetGORMTxhelper functions - Modified all GORM cache methods (Migrate, Set, Get, Del) to support optional transactions via context
- Added comprehensive test coverage for transaction commit, rollback, isolation, and delete scenarios
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| gorm.go | Implements transaction support using context pattern with cmp.Or fallback for all cache operations |
| gorm_test.go | Updates test helper to return DB instance and adds four comprehensive transaction tests |
| ristretto_test.go | Simplifies type parameter usage in test helper by relying on type inference |
| client_test.go | Updates test to accommodate new test helper signature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
buggoing
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xRef: