Conversation
There was a problem hiding this comment.
Pull request overview
This pull request refactors the codebase by renaming StateTooStale to StateRotten for improved clarity in describing the state of cached data that has exceeded both fresh and stale TTLs and must be refreshed.
- Renames the constant
StateTooStaletoStateRottenacross all code, tests, and documentation - Updates all comments, error messages, and test descriptions to use "rotten" terminology
- Maintains consistent behavior while improving code readability with more intuitive naming
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| types.go | Renamed StateTooStale constant to StateRotten and updated inline comment |
| error.go | Updated error message from "too stale" to "rotten" for consistency |
| entry_test.go | Renamed test cases and test data from "too stale" to "rotten" terminology |
| entry.go | Updated return statement to use StateRotten |
| client_test.go | Updated test names, assertions, and most comments to use "rotten" terminology; one inline comment needs update |
| client.go | Updated case statements and comments from "Too stale" to "Rotten" |
| README.md | Updated documentation diagrams and code examples to reflect new terminology |
| README_ZH.md | Updated Chinese documentation to reflect new terminology |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…new naming convention
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xRef: