Open
Conversation
snowykte0426
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
datagsm-server PR #273, PR #276의 변경사항을 반영하여 학생 도메인에 GitHub 아이디 필드 및 조회 필터를 추가합니다.
변경사항
Student 모델 확장 (PR #273)
Student모델에github_id필드 추가 (서버 응답 필드명:githubId)Student모델에github_url필드 추가 (서버 응답 필드명:githubUrl, 형식:https://github.com/{githubId})Optional[str]로, GitHub 아이디 미설정 학생의 경우None반환학생 조회 필터 파라미터 추가 (PR #276)
StudentRequest에major파라미터 추가 (학과 일치 필터)StudentRequest에github_id파라미터 추가 (GitHub ID 부분 일치 필터)SDK 버전 업데이트
1.0.3→1.0.4참고