-
Notifications
You must be signed in to change notification settings - Fork 0
[feat] 서버 최신 스펙 반영 (동아리/학생 필터, 응답 타입 정리) #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
junjuny0227
wants to merge
2
commits into
main
Choose a base branch
from
feat/club-student-filters-and-types-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+58
−63
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,34 @@ | ||
| import type { ClubType, ParticipantInfo, SortDirection } from './index'; | ||
| import type { ApiResponse, ClubType, ParticipantInfo, SortDirection } from './index'; | ||
|
|
||
| export type ClubSortBy = 'ID' | 'NAME' | 'TYPE'; | ||
| export type ClubStatus = 'ACTIVE' | 'ABOLISHED'; | ||
| export type ClubSortBy = 'ID' | 'NAME' | 'TYPE' | 'FOUNDED_YEAR' | 'STATUS'; | ||
|
|
||
| export interface Club { | ||
| id: number; | ||
| name: string; | ||
| type: ClubType; | ||
| leader: ParticipantInfo; | ||
| leader?: ParticipantInfo; | ||
| participants: ParticipantInfo[]; | ||
| foundedYear: number; | ||
| status: ClubStatus; | ||
| abolishedYear?: number; | ||
| } | ||
|
|
||
| export interface GetClubsRequest { | ||
| clubId?: number; | ||
| clubName?: string; | ||
| clubType?: ClubType; | ||
| clubStatus?: ClubStatus; | ||
| foundedYear?: number; | ||
| page?: number; | ||
| size?: number; | ||
| includeLeaderInParticipants?: boolean; | ||
| sortBy?: ClubSortBy; | ||
| sortDirection?: SortDirection; | ||
| } | ||
|
|
||
| export interface GetClubsResponse { | ||
| status: string; | ||
| code: number; | ||
| message: string; | ||
| data: { | ||
| totalPages: number; | ||
| totalElements: number; | ||
| clubs: Club[]; | ||
| }; | ||
| } | ||
| export type GetClubsResponse = ApiResponse<{ | ||
| totalPages: number; | ||
| totalElements: number; | ||
| clubs: Club[]; | ||
| }>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| export interface HealthCheckResponse { | ||
| status: string; | ||
| code: number; | ||
| message: string; | ||
| } | ||
| import type { ApiResponse } from './index'; | ||
|
|
||
| export type HealthCheckResponse = Omit<ApiResponse<never>, 'data'>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sdk와는 관련이 없지만 이것을 보고 알게 된건데 생각해보니 서버에서 요청을 할때 github 관련 정보나 전공 등 최근 추가된 파라미터들론 검색을 할수가 없던데 이런것들을 서버에서 작업해야 할까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
예를 들어 어떤 방식을 말씀하시는 건가요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
특정 전공인 학생을 검색한다거나, 그런 것들을 말씀하신 건가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
검색 파라미터로 전공 문자열,github ID를 전달할 수 있도록 하는 것을 말한겁니다!
예를 들어 junjun을 파라미터로 전달하면 3415 전준연이 조회되도록 하는 그런 식으로요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
특정 전공(예: 프론트엔드)을 검색했을 때 해당 전공의 학생 목록이 반환되는 기능은 충분히 활용 가치가 있을 것 같습니다. 그런데 개인적으로는 GitHub ID로 학생을 검색하는 경우는 그렇게 많지 않을 것 같습니다. 그래도 기능이 있다면 특정 상황에서는 유용하게 활용될 수 있을 것 같네요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
작업을 진행한다면 오늘 내로 작업이 가능할 것 같긴 한데 우선 진행해보겠습니다.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
서버 측 작업 진행하였습니다.
코드베이스 확인 결과 전공이 누락된게 아니라 학과가 누락되어 있었어서 이를 수정하였습니다